PYTHON-6059 Skip CSOT unified tests when running with coverage - #3014
Open
NoahStapp wants to merge 1 commit into
Open
PYTHON-6059 Skip CSOT unified tests when running with coverage#3014NoahStapp wants to merge 1 commit into
NoahStapp wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Unified Test Format runner to skip CSOT unified tests when running the test suite under coverage, to avoid known inconsistencies/flakiness in that mode.
Changes:
- Skip CSOT unified tests when
COVERAGEis set in the environment (sync runner). - Skip CSOT unified tests when
COVERAGEis set in the environment (async runner).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/unified_format.py | Adds a coverage-mode skip for CSOT unified tests in the synchronous UTF runner. |
| test/asynchronous/unified_format.py | Adds the same coverage-mode skip for CSOT unified tests in the asynchronous UTF runner. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+644
to
+645
| if "COVERAGE" in os.environ: | ||
| self.skipTest("CSOT tests are inconsistent with coverage") |
Comment on lines
+645
to
+646
| if "COVERAGE" in os.environ: | ||
| self.skipTest("CSOT tests are inconsistent with coverage") |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-XXXX
Changes in this PR
Skip CSOT unified tests when running with coverage. This does not include prose tests, which will be individually skipped in later tickets if they are flaky.
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer