PYTHON-6002 - Increase failpoint times for test_heartbeat_awaited_flag - #3011
Open
NoahStapp wants to merge 1 commit into
Open
PYTHON-6002 - Increase failpoint times for test_heartbeat_awaited_flag#3011NoahStapp wants to merge 1 commit into
NoahStapp wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the heartbeat failpoint configuration used by test_heartbeat_awaited_flag to reduce flakiness on slower hosts (per PYTHON-6002), by ensuring the failCommand failpoint does not exhaust its trigger count before a delayed heartbeat occurs.
Changes:
- Increase the
failCommandfailpoint trigger count from 2 to 4 intest_heartbeat_awaited_flag. - Apply the same change to both the asynchronous and synchronous variants of the streaming protocol test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_streaming_protocol.py | Increases the failpoint "mode.times" for the synchronous test_heartbeat_awaited_flag to reduce timing-related flakiness. |
| test/asynchronous/test_streaming_protocol.py | Increases the failpoint "mode.times" for the async test_heartbeat_awaited_flag to reduce timing-related flakiness. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6002
Changes in this PR
The
test_heartbeat_awaited_flagtest can fail on slower hosts due to the changes in SERVER-128517. This PR increases the number of times the test's failpoint triggers to eliminate those possible failures.Test Plan
Test changes.
Checklist
Checklist for Author
Checklist for Reviewer