test: build zonbud, zonbudusg and mfusgt with the meson build file they provide - #315
Open
jdhughes-dev wants to merge 1 commit into
Open
test: build zonbud, zonbudusg and mfusgt with the meson build file they provide#315jdhughes-dev wants to merge 1 commit into
jdhughes-dev wants to merge 1 commit into
Conversation
…ey provide The source zip file for these targets included meson.build but not meson.options, so meson stopped with 'Option double does not exist' and pymake fell back to a generated build file. The releases have been remade with meson.options included, so the fallback is no longer reached and the targets are no longer exempt from the assert that the provided build file was used. mfusgt is updated to 2.6.2, which is the release the archive was remade in.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #315 +/- ##
=============================================
+ Coverage 79.671% 79.866% +0.194%
=============================================
Files 20 20
Lines 3591 3591
=============================================
+ Hits 2861 2868 +7
+ Misses 730 723 -7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source zip file for these targets included
meson.buildbut notmeson.options, so meson stopped withOption double does not existand pymake fell back to a generated build file. The releases have been remade withmeson.optionsincluded (MODFLOW-ORG/zonbud#22, MODFLOW-ORG/zonbudusg#23, MODFLOW-ORG/mfusgt#26), sotest_meson_artifactsno longer exempts them from the assert that the provided build file was used.mfusgtis updated to 2.6.2, the release its archive was remade in.