fix(download): request the macarm asset on Apple Silicon - #314
Open
jdhughes-dev wants to merge 1 commit into
Open
fix(download): request the macarm asset on Apple Silicon#314jdhughes-dev wants to merge 1 commit into
jdhughes-dev wants to merge 1 commit into
Conversation
The executables and modflow6-nightly-build releases stopped building a mac.zip asset after release 25.0 and now ship macarm.zip as the only macOS asset, so getmfexes and getmfnightly asked for an asset that no longer exists and failed with a 404 on Apple Silicon. The macOS asset is now selected from the machine architecture, and macarm is accepted as a platform value. A test asserts that the asset detected for the current platform exists in the release, which fails on develop.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #314 +/- ##
=============================================
- Coverage 79.710% 79.671% -0.039%
=============================================
Files 20 20
Lines 3588 3591 +3
=============================================
+ Hits 2860 2861 +1
- Misses 728 730 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The executables and modflow6-nightly-build releases stopped building a
mac.zipasset after release 25.0 and now shipmacarm.zipas the only macOS asset, sogetmfexesandgetmfnightlyasked for an asset that no longer exists and failed with a 404 on Apple Silicon.The macOS asset is now selected from the machine architecture, and
macarmis accepted as a platform value.test_detected_assetasserts that the asset detected for the current platform exists in the release, and fails on develop with'mac.zip' not in {...}.