fix: fall back when server discovery times out - #1149
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
T-documentation
DaleSeo
marked this pull request as ready for review
August 7, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1142.
Motivation and Context
The 2026-07-28 backward compatibility guidance says that clients should fall back if the server does not respond to
server/discoverwithin a reasonable timeout. Previously,discover_startupwaited until it received a message or the transport closed.This PR adds a 10-second timeout to the Auto discovery probe. Explicit
Discoverstartup and legacy initialization remain unchanged. With this change, a connected legacy server that silently ignoresserver/discoverfalls back toinitializeinstead of hanging indefinitely.How Has This Been Tested?
Added regression tests.
Breaking Changes
None.
Types of changes
Checklist