fix(streamable-http): fail request when resumable SSE stream can't complete#2732
Open
Epochex wants to merge 4 commits into
Open
fix(streamable-http): fail request when resumable SSE stream can't complete#2732Epochex wants to merge 4 commits into
Epochex wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1577.
When a POST responds with ext/event-stream and the stream disconnects before a terminal JSON-RPC response/error arrives, the client transport tries to resume via GET + Last-Event-ID. If the server is gone (session 404s) or resumption otherwise can't succeed, the current code returns silently after exhausting retries.
Because ClientSession defaults to
ead_timeout_seconds=None, the original send_request() waits forever on the missing response.
Changes:
Tests: