fix: drain terminal streamable HTTP responses#2721
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
Author
|
Closing this because #2712 already covers the same streamable HTTP SSE drain path. I missed that existing PR during duplicate search, so keeping this open would only add review noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2707.
The streamable HTTP client currently closes SSE responses as soon as it reads the terminal JSON-RPC response or error. With HTTP keepalive, that can leave unread response bytes on the connection and force the next request down a fresh connection path.
This changes the request SSE paths to treat the terminal JSON-RPC message as logical completion, but still drain the response stream to EOF before returning. Cancellation and shutdown paths still close the stream via the existing context managers.
Testing