Skip to content

Add Oracle database connection configuration and robustness improvements#2

Open
mo74m3ed with Copilot wants to merge 3 commits into
copilot/fix-missing-feed-iconsfrom
copilot/5a4bdd72fcf3dcc1465d70363c3b5b0b39445242
Open

Add Oracle database connection configuration and robustness improvements#2
mo74m3ed with Copilot wants to merge 3 commits into
copilot/fix-missing-feed-iconsfrom
copilot/5a4bdd72fcf3dcc1465d70363c3b5b0b39445242

Conversation

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown

The repository lacked database driver support and configuration parameters for Oracle DB.

This pull request introduces Oracle connection capabilities to the database service registry, ensuring compatibility with Oracle databases and isolated environment configurations.

Database Configuration

  • Added the oracle database connection block to config/database.php utilizing unique ORACLE_DB_ environment variables to prevent host/credential namespace collisions with primary databases.
'oracle' => [
    'driver' => 'oracle',
    'host' => env('ORACLE_DB_HOST', '127.0.0.1'),
    'port' => env('ORACLE_DB_PORT', '1521'),
    'database' => env('ORACLE_DB_DATABASE', 'xe'),
    'username' => env('ORACLE_DB_USERNAME', 'system'),
    'password' => env('ORACLE_DB_PASSWORD', ''),
    'charset' => env('ORACLE_DB_CHARSET', 'AL32UTF8'),
    'prefix' => env('ORACLE_DB_PREFIX', ''),
    'prefix_indexes' => true,
],

Environment Templates

  • Updated .env.example with standard Oracle configuration keys and documented default fallback values.

Test Coverage & Robustness

  • Added tests/Unit/OracleDatabaseConfigTest.php to verify full resolution, driver mapping, default fallback integrity, and prefix options.
  • Patched floating-point precision comparisons in tests/Unit/InventoryTotalCostTest.php using rounding to eliminate flaky test runs.

@mo74m3ed
mo74m3ed marked this pull request as ready for review July 16, 2026 11:43
@mo74m3ed
mo74m3ed self-requested a review July 16, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants