Open
Add locale-aware inventory sorting via PHP Collator (mirrors FreshRSS#8985)#1
Conversation
Copilot
AI
changed the title
Add locale-aware inventory sorting via LocaleHelper (mirrors FreshRSS#8985)
Add locale-aware inventory sorting via PHP Collator (mirrors FreshRSS#8985)
Jul 7, 2026
Copilot created this pull request from a session on behalf of
mo74m3ed
July 7, 2026 18:40
View session
mo74m3ed
approved these changes
Jul 10, 2026
mo74m3ed
marked this pull request as ready for review
July 10, 2026 04:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strnatcasecmp()compares raw UTF-8 bytes, so accented names (Ábaco,Ñandú) sort after all ASCII names regardless of locale. Replaces byte-order comparison with PHP'sCollator(ext-intl) so inventory names sort correctly for the application locale, with astrnatcasecmpfallback whenext-intlis unavailable.Changes
app/Helpers/LocaleHelper(new) — staticlocaleCompare(string $a, string $b): intusingCollator::create(app()->getLocale())withNUMERIC_COLLATIONenabled; caches the collator statically; falls back tostrnatcasecmp(); exposesresetCollator()for test isolation.app/Actions/Inventory/InventoryListAction— fetches all records, sorts globally viauasort + LocaleHelper::localeCompare(), then paginates manually. Per-page limit clamped toMAX_PER_PAGE = 100; limits extracted to class constants.tests/Unit/LocaleHelperTest(new) — covers less/equal/greater comparisons and the Spanish accent ordering case.