Fix: update raw attributes when appending cHPI channels - #14180
Merged
Conversation
christianbrodbeck
marked this pull request as ready for review
August 19, 2026 14:48
christianbrodbeck
requested review from
agramfort,
drammock and
larsoner
as code owners
August 19, 2026 14:48
larsoner
approved these changes
Aug 19, 2026
larsoner
left a comment
larsoner
left a comment
Member
There was a problem hiding this comment.
Maybe someday we should instead create a mini RawFIF instance and raw.append(chpi_raw)... it should take care of all of this stuff and would be more DRY. But in the meantime I think this works. Thanks @christianbrodbeck !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When appending cHPI channels to raw, some private attributes containing by-channel information need to be updated to enable subsequent indexing operations to work.
Additional information
Claude Opus 5 identified the issue and implemented the tests and fix. GPT-5.6 Sol reviewed change and identified issue with concatenation (in comment).