deps: bump measure-mirror pin → v0.28.1 (power_check honesty fix)#21
Merged
Conversation
Propagates measure-mirror #33 to mm_power_check: power_check now honors
alpha/target_power instead of hardcoding z_alpha2=1.96/z_beta=0.842. The old
probe printed the requested power ('at 99% power') while always computing n at
80% — text and number lied to each other. Now target_power=0.99 → n≥1829 (was
781), alpha=0.0001 → n≥2229; default (α=0.05, power=0.80) unchanged. zero-dep
preserved (statistics.NormalDist, stdlib).
Pin recorded as full 40-hex SHA (abe0c19d…); the v0.28.0 bump #20 had landed a
9-hex abbreviation that blinded the cross-repo pin-lag checker, since normalized.
mcp 0.2.8 → 0.2.9; CHANGELOG updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
머지: measure-mirror 핀 → v0.28.1 (power_check 정직성 픽스를 mm_power_check로 전파). 풀 40-hex SHA·mcp 0.2.9. CI 4/4 그린. 대장님 승인. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates measure-mirror #33 to the
mm_power_checktool.What
power_checkhardcoded its critical values (z_alpha2=1.96,z_beta=0.842), so it printed the requested power (e.g. "at 99% power") while the required-n was always computed at 80% power / α=0.05 — the text and the number contradicted each other (a text-vs-number lie, the worst class of defect for an honesty-audit tool). Fixed upstream to derive both z-values fromalpha/target_powerviastatistics.NormalDist().inv_cdf(stdlib, zero-dep).target_power=0.99→ n≥1829 (was 781)alpha=0.0001→ n≥2229Until this pin bump,
mm_power_checkserves the buggy probe — this is a functional propagation, not docs.Change
28290f2(v0.28.0) →abe0c19(v0.28.1), recorded as full 40-hex SHACI green upstream (measure-mirror #33: 4/4). Pin surface → human gate per triage guardrail #10.