Mempool: fix spuriouly failing test; shrink hash tables; some cleanup.#2080
Open
ImplOfAnImpl wants to merge 2 commits into
Open
Mempool: fix spuriouly failing test; shrink hash tables; some cleanup.#2080ImplOfAnImpl wants to merge 2 commits into
ImplOfAnImpl wants to merge 2 commits into
Conversation
OBorce
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the switch to using hashbrown tables in mempool, the test
mempool_full_realcan fail spuriously, because now removing a tx from a full mempool and inserting one with the same size is not guaranteed to succeed (this is because hashbrown tables leave a tombstone instead of a removed element, which may not always be re-used during insertion). So the test had to be relaxed.Mempool will now try to shrink its hashtables' capacities from time to time.
Note that I initially implemented this to handle a degenerate case where an attacker would fill the mempool with 200'000 small transactions, which may permanently occupy up to 40Mb worth of capacity in the hashtables, thus reducing the effective mempool size by the same 40Mb. But then I noticed that we actually recreate the whole mempool store each time the mempool reorgs to a new tip, so the degenerate case may exist for several minutes at best. But IMO it's better to keep the shrinkage logic, at least as a fail-safe.
Small cleanup - MempoolStore's fields are now non-public.