Move to JDK 25 for build only

.gitattributes

@@ -1 +1,14 @@
-* text eol=lf
+# Normalize text files to LF, but let Git auto-detect binaries so they are
+# stored byte-for-byte (a blanket "* text" corrupts binaries like the Gradle
+# wrapper jar by stripping CR bytes during line-ending normalization).
+* text=auto eol=lf
+
+# Always treat these as binary regardless of auto-detection.
+*.jar binary
+*.zip binary
+*.gz binary
+*.class binary
+*.png binary
+*.jpg binary
+*.gif binary
+*.ico binary

.github/workflows/gradle.yml

@@ -29,11 +29,11 @@ jobs:
             exit 1
           fi
 
-      - name: Setup java 17 for building
+      - name: Setup java 25 for building
         uses: actions/setup-java@v5
         with:
           distribution: temurin
-          java-version: '17'
+          java-version: '25'
 
       - name: Set environment variables on Ubuntu
         if: matrix.os == 'ubuntu-latest'
@@ -59,7 +59,7 @@ jobs:
           ./gradlew.bat build
 
       - name: Setup java ${{ matrix.java-version }} for testing
-        if: matrix.java-version != '17'
+        if: matrix.java-version != '25'
         uses: actions/setup-java@v5
         with:
           distribution: temurin
@@ -69,20 +69,20 @@ jobs:
         if: matrix.os == 'ubuntu-latest'
         run: |
           cd functional
-          curl -sSfLO https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.11.4/junit-platform-console-standalone-1.11.4.jar
-          curl -sSfLO https://repo1.maven.org/maven2/com/github/spotbugs/spotbugs-annotations/4.9.8/spotbugs-annotations-4.9.8.jar
-          javac -cp spotbugs-annotations-4.9.8.jar:junit-platform-console-standalone-1.11.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:../adminapi/build/libs/minio-admin-${DEV_VERSION}-all.jar:. FunctionalTest.java
-          java -cp spotbugs-annotations-4.9.8.jar:junit-platform-console-standalone-1.11.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:../adminapi/build/libs/minio-admin-${DEV_VERSION}-all.jar:. FunctionalTest
-          javac -cp spotbugs-annotations-4.9.8.jar:junit-platform-console-standalone-1.11.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:. ./TestUserAgent.java
-          java -Dversion=${DEV_VERSION} -cp spotbugs-annotations-4.9.8.jar:junit-platform-console-standalone-1.11.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:. TestUserAgent
-          javac -cp spotbugs-annotations-4.9.8.jar:junit-platform-console-standalone-1.11.4.jar:../api/build/libs/minio-${RELEASE_VERSION}-all.jar:. ./TestUserAgent.java
-          java -Dversion=${RELEASE_VERSION} -cp spotbugs-annotations-4.9.8.jar:junit-platform-console-standalone-1.11.4.jar:../api/build/libs/minio-${RELEASE_VERSION}-all.jar:. TestUserAgent
+          curl -sSfLO https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.14.4/junit-platform-console-standalone-1.14.4.jar
+          curl -sSfLO https://repo1.maven.org/maven2/com/github/spotbugs/spotbugs-annotations/4.10.2/spotbugs-annotations-4.10.2.jar
+          javac -cp spotbugs-annotations-4.10.2.jar:junit-platform-console-standalone-1.14.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:../adminapi/build/libs/minio-admin-${DEV_VERSION}-all.jar:. FunctionalTest.java
+          java -cp spotbugs-annotations-4.10.2.jar:junit-platform-console-standalone-1.14.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:../adminapi/build/libs/minio-admin-${DEV_VERSION}-all.jar:. FunctionalTest
+          javac -cp spotbugs-annotations-4.10.2.jar:junit-platform-console-standalone-1.14.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:. ./TestUserAgent.java
+          java -Dversion=${DEV_VERSION} -cp spotbugs-annotations-4.10.2.jar:junit-platform-console-standalone-1.14.4.jar:../api/build/libs/minio-${DEV_VERSION}-all.jar:. TestUserAgent
+          javac -cp spotbugs-annotations-4.10.2.jar:junit-platform-console-standalone-1.14.4.jar:../api/build/libs/minio-${RELEASE_VERSION}-all.jar:. ./TestUserAgent.java
+          java -Dversion=${RELEASE_VERSION} -cp spotbugs-annotations-4.10.2.jar:junit-platform-console-standalone-1.14.4.jar:../api/build/libs/minio-${RELEASE_VERSION}-all.jar:. TestUserAgent
 
       - name: Run tests on Windows
         if: matrix.os == 'windows-latest'
         run: |
           cd functional
-          curl -sSfLO https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.11.4/junit-platform-console-standalone-1.11.4.jar
-          curl -sSfLO https://repo1.maven.org/maven2/com/github/spotbugs/spotbugs-annotations/4.9.8/spotbugs-annotations-4.9.8.jar
-          javac -encoding UTF-8 -cp "spotbugs-annotations-4.9.8.jar;junit-platform-console-standalone-1.11.4.jar;../api/build/libs/minio-$Env:DEV_VERSION-all.jar;../adminapi/build/libs/minio-admin-$Env:DEV_VERSION-all.jar;." FunctionalTest.java
-          java -cp "spotbugs-annotations-4.9.8.jar;junit-platform-console-standalone-1.11.4.jar;../api/build/libs/minio-$Env:DEV_VERSION-all.jar;../adminapi/build/libs/minio-admin-$Env:DEV_VERSION-all.jar;." FunctionalTest
+          curl -sSfLO https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.14.4/junit-platform-console-standalone-1.14.4.jar
+          curl -sSfLO https://repo1.maven.org/maven2/com/github/spotbugs/spotbugs-annotations/4.10.2/spotbugs-annotations-4.10.2.jar
+          javac -encoding UTF-8 -cp "spotbugs-annotations-4.10.2.jar;junit-platform-console-standalone-1.14.4.jar;../api/build/libs/minio-$Env:DEV_VERSION-all.jar;../adminapi/build/libs/minio-admin-$Env:DEV_VERSION-all.jar;." FunctionalTest.java
+          java -cp "spotbugs-annotations-4.10.2.jar;junit-platform-console-standalone-1.14.4.jar;../api/build/libs/minio-$Env:DEV_VERSION-all.jar;../adminapi/build/libs/minio-admin-$Env:DEV_VERSION-all.jar;." FunctionalTest

adminapi/src/main/java/io/minio/admin/MinioAdminClient.java

@@ -453,8 +453,10 @@ public long getBucketQuota(String bucketName) throws MinioException {
           OBJECT_MAPPER
               .getTypeFactory()
               .constructMapType(HashMap.class, String.class, JsonNode.class);
-      return OBJECT_MAPPER.<Map<String, JsonNode>>readValue(response.body().bytes(), mapType)
-          .entrySet().stream()
+      return OBJECT_MAPPER
+          .<Map<String, JsonNode>>readValue(response.body().bytes(), mapType)
+          .entrySet()
+          .stream()
           .filter(entry -> "quota".equals(entry.getKey()))
           .findFirst()
           .map(entry -> Long.valueOf(entry.getValue().toString()))

api/src/main/java/io/minio/Checksum.java

@@ -33,6 +33,7 @@
 public class Checksum {
   /** MD5 hash of zero length byte array. */
   public static final String ZERO_MD5_HASH = "1B2M2Y8AsgTpgAmY7PhCfg==";
+
   /** SHA-256 hash of zero length byte array. */
   public static final String ZERO_SHA256_HASH =
       "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855";

api/src/main/java/io/minio/Http.java

@@ -890,7 +890,7 @@ public static OkHttpClient setTimeout(
         .build();
   }
 
-  /** HTTP body of {@link RandomAccessFile}, {@link ByteBuffer} or {@link byte} array. */
+  /** HTTP body of {@link RandomAccessFile}, {@link ByteBuffer} or {@code byte} array. */
   public static class Body {
     private okhttp3.RequestBody requestBody;
     private RandomAccessFile file;

api/src/main/java/io/minio/PartReader.java

@@ -96,7 +96,8 @@ private void readOneByte() throws MinioException {
     int n = 0;
 
     try {
-      while ((n = file != null ? file.read(oneByte) : stream.read(oneByte)) == 0) ;
+      while ((n = file != null ? file.read(oneByte) : stream.read(oneByte)) == 0)
+        ;
     } catch (IOException e) {
       throw new MinioException(e);
     }

api/src/main/java/io/minio/errors/MinioException.java

@@ -62,12 +62,26 @@ public String httpTrace() {
 
   /** Throws encapsulated exception. */
   public void throwEncapsulatedException()
-      throws BucketPolicyTooLargeException, CertificateException, EOFException,
-          ErrorResponseException, FileNotFoundException, GeneralSecurityException,
-          InsufficientDataException, InternalException, InvalidKeyException,
-          InvalidResponseException, IOException, JsonMappingException, JsonParseException,
-          JsonProcessingException, KeyManagementException, KeyStoreException, MinioException,
-          NoSuchAlgorithmException, ServerException, XmlParserException {
+      throws BucketPolicyTooLargeException,
+          CertificateException,
+          EOFException,
+          ErrorResponseException,
+          FileNotFoundException,
+          GeneralSecurityException,
+          InsufficientDataException,
+          InternalException,
+          InvalidKeyException,
+          InvalidResponseException,
+          IOException,
+          JsonMappingException,
+          JsonParseException,
+          JsonProcessingException,
+          KeyManagementException,
+          KeyStoreException,
+          MinioException,
+          NoSuchAlgorithmException,
+          ServerException,
+          XmlParserException {
     Throwable e = getCause();
 
     // Inherited by MinioException

build.gradle

@@ -15,14 +15,14 @@
  */
 
 /********************************/
-/*   gradleVersion = '9.4.1'    */
+/*   gradleVersion = '9.6.0'    */
 /********************************/
 
 plugins {
-    id 'com.gradleup.shadow' version '9.0.0'
-    id 'com.github.spotbugs' version '6.5.1'
-    id 'org.jreleaser' version '1.23.0'
-    id 'com.diffplug.spotless' version '6.13.0'
+    id 'com.gradleup.shadow' version '9.4.2'
+    id 'com.github.spotbugs' version '6.5.8'
+    id 'org.jreleaser' version '1.24.0'
+    id 'com.diffplug.spotless' version '8.7.0'
 }
 
 /* Root project definitions */
@@ -48,22 +48,26 @@ subprojects {
     dependencies {
         api 'com.carrotsearch.thirdparty:simple-xml-safe:2.7.1'
         api 'com.google.guava:guava:33.6.0-jre'
-        api 'com.squareup.okhttp3:okhttp:5.3.2'
-        api 'com.fasterxml.jackson.core:jackson-annotations:2.21'
-        api 'com.fasterxml.jackson.core:jackson-core:2.21.2'
-        api 'com.fasterxml.jackson.core:jackson-databind:2.21.2'
+        api 'com.squareup.okhttp3:okhttp:5.4.0'
+        api 'com.fasterxml.jackson.core:jackson-annotations:2.22'
+        api 'com.fasterxml.jackson.core:jackson-core:2.22.0'
+        api 'com.fasterxml.jackson.core:jackson-databind:2.22.0'
         api 'org.bouncycastle:bcprov-jdk18on:1.84'
         api 'org.apache.commons:commons-compress:1.28.0'
-        api 'commons-codec:commons-codec:1.21.0'
+        api 'commons-codec:commons-codec:1.22.0'
         api 'org.xerial.snappy:snappy-java:1.1.10.8'
-        compileOnly 'com.github.spotbugs:spotbugs-annotations:4.9.8'
+        compileOnly 'com.github.spotbugs:spotbugs-annotations:4.10.2'
 
-        testImplementation 'com.squareup.okhttp3:mockwebserver:5.3.2'
-        testImplementation 'org.junit.jupiter:junit-jupiter-api:5.14.3'
+        testImplementation 'com.squareup.okhttp3:mockwebserver:5.4.0'
+        testImplementation 'org.junit.jupiter:junit-jupiter-api:5.14.4'
     }
 
     [compileJava, compileTestJava].each() {
         it.options.fork = true
+        // Build runs on JDK 25 (see java.toolchain) but enforces the Java 8 API surface and
+        // emits Java 8 bytecode via --release 8. --release also avoids the "source/target 8 is
+        // obsolete" warning; -Xlint:-options is kept as a belt-and-braces guard for -Werror.
+        it.options.release = 8
         it.options.compilerArgs += ['-Xlint:unchecked', '-Xlint:deprecation', '-Xlint:-options', '-Werror', '-Xdiags:verbose']
         it.options.encoding = 'UTF-8'
     }
@@ -103,6 +107,10 @@ subprojects {
     check.dependsOn localeTest
 
     java {
+        // Compile/test/javadoc run on JDK 25; bytecode/API level pinned to Java 8 via release below.
+        toolchain {
+            languageVersion = JavaLanguageVersion.of(25)
+        }
         sourceCompatibility = JavaVersion.VERSION_1_8
         targetCompatibility = JavaVersion.VERSION_1_8
     }
@@ -112,7 +120,7 @@ subprojects {
             target '**/*.java'
             importOrder 'edu', 'com', 'io', 'java', 'javax', 'org', ''
             removeUnusedImports()
-            googleJavaFormat('1.7')
+            googleJavaFormat('1.35.0')
         }
         groovyGradle {
             target '*.gradle'
@@ -226,7 +234,7 @@ project(':api') {
     }
 
     signing {
-        required {
+        required = {
             gradle.taskGraph.allTasks.any { it.name.contains('LocalMavenWithChecksums') }
         }
         sign publishing.publications.minioJava
@@ -346,7 +354,7 @@ project(':adminapi') {
     }
 
     signing {
-        required {
+        required = {
             gradle.taskGraph.allTasks.any { it.name.contains('LocalMavenWithChecksums') }
         }
         sign publishing.publications.minioJava
@@ -355,7 +363,7 @@ project(':adminapi') {
 
 project(':examples') {
     dependencies {
-        compileOnly 'me.tongfei:progressbar:0.9.5'
+        compileOnly 'me.tongfei:progressbar:0.10.2'
         compileOnly project(':api')
     }
 
@@ -367,14 +375,17 @@ project(':examples') {
         main {
             java {
                 srcDirs = ["$rootDir/examples"]
+                // srcDir is the module root, which also contains build/; keep generated
+                // files (e.g. Spotless lint output) out of compilation.
+                exclude 'build/**'
             }
         }
     }
 }
 
 project(':functional') {
     dependencies {
-        implementation 'org.junit.jupiter:junit-jupiter-api:5.14.3'
+        implementation 'org.junit.jupiter:junit-jupiter-api:5.14.4'
         implementation project(':api')
         implementation project(':adminapi')
     }
@@ -387,6 +398,9 @@ project(':functional') {
         main {
             java {
                 srcDirs = ["$rootDir/functional"]
+                // srcDir is the module root, which also contains build/; keep generated
+                // files (e.g. Spotless lint output) out of compilation.
+                exclude 'build/**'
             }
         }
     }

functional/TestMinioClient.java

@@ -548,7 +548,9 @@ public void putObject() throws Exception {
 
     testPutObject(
         "[object name ends with '/']",
-        PutObjectArgs.builder().bucket(bucketName).object("path/to/" + getRandomName() + "/")
+        PutObjectArgs.builder()
+            .bucket(bucketName)
+            .object("path/to/" + getRandomName() + "/")
             .stream(new ContentInputStream(0), 0L, null)
             .contentType(CUSTOM_CONTENT_TYPE)
             .build(),
@@ -1445,7 +1447,9 @@ public void testCopyObject(
       client.makeBucket(MakeBucketArgs.builder().bucket(args.source().bucket()).build());
       try {
         PutObjectArgs.Builder builder =
-            PutObjectArgs.builder().bucket(args.source().bucket()).object(args.source().object())
+            PutObjectArgs.builder()
+                .bucket(args.source().bucket())
+                .object(args.source().object())
                 .stream(new ContentInputStream(1 * KB), 1L * KB, null);
         if (sse != null) builder.sse(sse);
         client.putObject(builder.build());

gradle/wrapper/gradle-wrapper.properties

@@ -1,7 +1,9 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.6.0-bin.zip
 networkTimeout=10000
+retries=0
+retryBackOffMs=500
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists