♻️ harmonize V2 CLI with other SDKs, add tests#432
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ianardee
requested changes
Jun 18, 2026
| polygon: bool = False | ||
| """Whether to expose ``--polygon/-p``.""" | ||
| text_context: bool = False | ||
| """Whether to expose ``--text-context/-t``.""" |
Contributor
There was a problem hiding this comment.
Same as PHP: this is not a good idea, most of the options are not shared.
Comment on lines
+61
to
+65
| PRODUCTS: dict[str, _ProductTypes] = { | ||
| "classification": _ProductTypes( | ||
| response_class=ClassificationResponse, | ||
| params_class=ClassificationParameters, | ||
| ), |
Contributor
There was a problem hiding this comment.
Makes more sense to define the options (rag, raw_text, etc) at the product level, since the options are integral part of the product.
Perhaps there is a way to get them from the actual XxxParameters class?
Contributor
There was a problem hiding this comment.
this is OK, but better to test the CLI directly rather than with synthetic testing.
ianardee
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes