Skip to content

Merge v4-beta to v4 (2026-06-09)#184

Merged
PaulNewling merged 4 commits into
v4from
merge-2026-06-09
Jun 9, 2026
Merged

Merge v4-beta to v4 (2026-06-09)#184
PaulNewling merged 4 commits into
v4from
merge-2026-06-09

Conversation

@PaulNewling

@PaulNewling PaulNewling commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Merge v4-beta into v4

Canary Tested:
platforma-open/clonotype-space#99
platforma-open/clonotype-space#98

Greptile Summary

This PR removes the catalog-bump detection path from the check-coverage action, so only direct edits to workspace package files trigger a changeset requirement. The change was motivated by a real regression (platforma-open/clonotype-space#95) where a pnpm-workspace.yaml catalog bump spuriously failed packages whose own files were never touched.

  • check-coverage.sh: Section 2b (catalog-consumer scan using yq + jq) is deleted entirely; the pkg_list_json temp file and its trap entry are removed alongside it. The script now only calls pnpm --filter '[<base>]' list to detect direct workspace-package edits.
  • action.yaml: Description updated to document the intentional non-flagging of dependency-version bumps and to drop yq from the tool requirements.
  • coverage.bats: Old catalog-failure tests replaced with regression tests that assert catalog bumps are silently ignored; the @test "named-catalog change …" known-limitation block is also removed since it tested removed code.

Confidence Score: 5/5

Safe to merge — the catalog-bump detection path is cleanly removed, the remaining direct-edit logic is unchanged, and tests cover the new behavior including the regression scenario that motivated the change.

The change is a targeted deletion: roughly 80 lines of catalog-bump scanning (yq + jq) are removed along with their temp file and trap entry, and the test suite is updated in lockstep. The surviving direct-edit detection path is untouched. The CI test workflow still verifies yq is present (needed by the bump_catalog test helper in helpers.bash), so test infrastructure remains coherent even though the production action no longer mentions yq. No logic is rewritten, only removed.

No files require special attention.

Important Files Changed

Filename Overview
actions/changeset/check-coverage/check-coverage.sh Removes catalog-bump detection (section 2b, ~80 lines) and the associated yq/jq workspace scan; now only direct-edit detection remains. Temp file and trap cleaned up consistently.
actions/changeset/check-coverage/action.yaml Description rewritten to document the intentional drop of catalog-bump flagging and to remove yq from the listed runtime requirements.
actions/changeset/check-coverage/test/coverage.bats Catalog test suite replaced: old "bump fails, bump passes, partial fail" tests removed; new tests assert catalog bumps are ignored (pass) and that a concurrent catalog bump does not expand the required set beyond directly-edited packages.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([PR diff against origin/BASE_BRANCH]) --> B[changeset status --since=origin/BASE_BRANCH]
    B --> C{status.json produced?}
    C -- no changeset message --> D[inject empty releases]
    C -- tooling error --> E([exit 2])
    C -- success --> F[build bumped_set from releases]
    D --> F
    F --> G["pnpm --filter '[origin/BASE_BRANCH]' list\n(direct-edit packages only)"]
    G --> H[build required_set\nskip private packages]
    H --> I{required_set ⊆ bumped_set?}
    I -- yes --> J([exit 0 ✓])
    I -- no --> K[print missing packages]
    K --> L([exit 1])

    style E fill:#f66,color:#fff
    style J fill:#6c6,color:#fff
    style L fill:#f66,color:#fff
Loading

Reviews (1): Last reviewed commit: "Merge v4-beta into v4" | Re-trigger Greptile

PaulNewling and others added 4 commits June 9, 2026 10:12
…ged vs pnpm changeset)

The check required a changeset for any package consuming a bumped catalog
dependency via `dependencies`/`peerDependencies`. That over-reports relative
to `pnpm changeset`: a catalog entry always pins an *external* package
(workspace packages use `workspace:*`, never `catalog:`), and changeset never
adds a package to its release plan because an external dependency's version
changed — it propagates bumps through the internal dependency chain
automatically at `changeset version` time.

Regression: platforma-open/clonotype-space#95. A `@platforma-sdk/workflow-tengo`
catalog bump (5.25.0 → 6.3.2) failed CI on the untouched `.workflow` package,
even though the PR's changeset (model/ui/block) was complete per `pnpm changeset`.

Remove section 2b (catalog-bump → require consumer) and its workspace-map /
yq parsing; keep direct-edit detection. The action no longer needs `yq`.

Tests: replace the catalog-bump cases (which asserted exit 1) with parity
cases asserting exit 0, including a regression mirroring the clonotype-space
shape (runtime `catalog:` dep bumps, consumer files untouched → passes). Drop
the now-moot named-catalog "known limitation" skip.
Cut the duplicated dependency-bump rationale at the direct-edit loop, lead the
header rule with a positive, and split the two-fact sentence for clarity.
Comment-only; no behavior change.
…log-overflag

ci(changeset/check-coverage): drop catalog-bump requirement (overflagged vs pnpm changeset)
@PaulNewling PaulNewling merged commit 9f7bbf9 into v4 Jun 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant