Merge v4-beta to v4 (2026-06-09)#184
Merged
Merged
Conversation
…ged vs pnpm changeset) The check required a changeset for any package consuming a bumped catalog dependency via `dependencies`/`peerDependencies`. That over-reports relative to `pnpm changeset`: a catalog entry always pins an *external* package (workspace packages use `workspace:*`, never `catalog:`), and changeset never adds a package to its release plan because an external dependency's version changed — it propagates bumps through the internal dependency chain automatically at `changeset version` time. Regression: platforma-open/clonotype-space#95. A `@platforma-sdk/workflow-tengo` catalog bump (5.25.0 → 6.3.2) failed CI on the untouched `.workflow` package, even though the PR's changeset (model/ui/block) was complete per `pnpm changeset`. Remove section 2b (catalog-bump → require consumer) and its workspace-map / yq parsing; keep direct-edit detection. The action no longer needs `yq`. Tests: replace the catalog-bump cases (which asserted exit 1) with parity cases asserting exit 0, including a regression mirroring the clonotype-space shape (runtime `catalog:` dep bumps, consumer files untouched → passes). Drop the now-moot named-catalog "known limitation" skip.
Cut the duplicated dependency-bump rationale at the direct-edit loop, lead the header rule with a positive, and split the two-fact sentence for clarity. Comment-only; no behavior change.
…log-overflag ci(changeset/check-coverage): drop catalog-bump requirement (overflagged vs pnpm changeset)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge v4-beta into v4
Canary Tested:
platforma-open/clonotype-space#99
platforma-open/clonotype-space#98
Greptile Summary
This PR removes the catalog-bump detection path from the
check-coverageaction, so only direct edits to workspace package files trigger a changeset requirement. The change was motivated by a real regression (platforma-open/clonotype-space#95) where apnpm-workspace.yamlcatalog bump spuriously failed packages whose own files were never touched.check-coverage.sh: Section 2b (catalog-consumer scan usingyq+jq) is deleted entirely; thepkg_list_jsontemp file and itstrapentry are removed alongside it. The script now only callspnpm --filter '[<base>]' listto detect direct workspace-package edits.action.yaml: Description updated to document the intentional non-flagging of dependency-version bumps and to dropyqfrom the tool requirements.coverage.bats: Old catalog-failure tests replaced with regression tests that assert catalog bumps are silently ignored; the@test "named-catalog change …"known-limitation block is also removed since it tested removed code.Confidence Score: 5/5
Safe to merge — the catalog-bump detection path is cleanly removed, the remaining direct-edit logic is unchanged, and tests cover the new behavior including the regression scenario that motivated the change.
The change is a targeted deletion: roughly 80 lines of catalog-bump scanning (yq + jq) are removed along with their temp file and trap entry, and the test suite is updated in lockstep. The surviving direct-edit detection path is untouched. The CI test workflow still verifies yq is present (needed by the bump_catalog test helper in helpers.bash), so test infrastructure remains coherent even though the production action no longer mentions yq. No logic is rewritten, only removed.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A([PR diff against origin/BASE_BRANCH]) --> B[changeset status --since=origin/BASE_BRANCH] B --> C{status.json produced?} C -- no changeset message --> D[inject empty releases] C -- tooling error --> E([exit 2]) C -- success --> F[build bumped_set from releases] D --> F F --> G["pnpm --filter '[origin/BASE_BRANCH]' list\n(direct-edit packages only)"] G --> H[build required_set\nskip private packages] H --> I{required_set ⊆ bumped_set?} I -- yes --> J([exit 0 ✓]) I -- no --> K[print missing packages] K --> L([exit 1]) style E fill:#f66,color:#fff style J fill:#6c6,color:#fff style L fill:#f66,color:#fffReviews (1): Last reviewed commit: "Merge v4-beta into v4" | Re-trigger Greptile