fix: exclude arm64 MSAL runtime from VersionInfo sanity - #329628
Open
Anthony Kim (anthonykim1) wants to merge 5 commits into
Open
fix: exclude arm64 MSAL runtime from VersionInfo sanity#329628Anthony Kim (anthonykim1) wants to merge 5 commits into
Anthony Kim (anthonykim1) wants to merge 5 commits into
Conversation
win32-arm64 scheduled builds fail validateAllVersionInfo on msalruntime_arm64.dll from @github/copilot-win32-arm64. The DLL has the same unusable ProductName VersionInfo as the already-excluded x64 msalruntime.dll; cover both names.
Contributor
There was a problem hiding this comment.
Pull request overview
Extends Windows VersionInfo sanity exclusions for the Copilot-vendored ARM64 MSAL runtime DLL.
Changes:
- Excludes
msalruntime_arm64.dll. - Documents existing and new DLL exclusions.
Show a summary per file
| File | Description |
|---|---|
test/sanity/src/context.ts |
Adds the ARM64 MSAL runtime to the VersionInfo exclusion regex. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
Author
Contributor
Author
Anthony Kim (anthonykim1)
marked this pull request as ready for review
August 7, 2026 21:57
Anthony Kim (anthonykim1)
marked this pull request as draft
August 7, 2026 21:57
Anthony Kim (anthonykim1)
marked this pull request as ready for review
August 7, 2026 22:05
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
August 7, 2026 22:05
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Dmitriy Vasyura (@dmitrivMS)Matched files:
|
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/microsoft/vscode-engineering/issues/3529
msalruntime_arm64.dllis skipped the same way as x64msalruntime.dll.dxil.dll/ffmpeg.dllexcludes unchanged.validateAllVersionInfoon empty Windows-visible ProductName for the arm64 MSAL runtime DLL.Inspirations from:
dxil.dll/ffmpeg.dll/msalruntime.dll) comes fromversionInfoFileExclude.versionInfoPathExcludefor MXC SDK bins.