Skip to content

[cherry-pick] chore: bump electron@42.8.0 to fix standard-user startup crash - #329594

Open
Akshat Anand (cipheraxat) wants to merge 1 commit into
microsoft:release/1.132from
cipheraxat:fix/329530-release-1.132-electron-42.8.0
Open

[cherry-pick] chore: bump electron@42.8.0 to fix standard-user startup crash#329594
Akshat Anand (cipheraxat) wants to merge 1 commit into
microsoft:release/1.132from
cipheraxat:fix/329530-release-1.132-electron-42.8.0

Conversation

@cipheraxat

@cipheraxat Akshat Anand (cipheraxat) commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks the Electron 42.8.0 runtime bump from #328712 onto release/1.132.

Fixes #329530 — on 1.132.0 (system install), launching Code as a standard Windows user (no admin rights) crash-loops at startup:

  • GPU process launch failed: error_code=57 (repeats until GPU process isn't usable. Goodbye.)
  • renderer gone with reason: launch-failed, code: 57
  • network service crash-restarts in a loop
  • crashpad: crash server failed to launch, self-terminating

The reporter confirmed 1.133.0 Insiders (Electron 42.8.0) does not crash with the same steps. I diffed every launch-related path between release/1.132 and main (src/main.ts, src/vs/code/, src/vs/platform/windows/electron-main/, crashpad config, build/win32/, resources/win32/) and found zero changes — the only difference between the crashing build and the working one is the Electron runtime, so this is not fixable in VS Code source. #328712 also references the internal runtime fix (vscode-internalbacklog#8662).

The only conflict was package.json's version/distro, resolved to keep the release branch's 1.132.0 / b2ef7d8... pins.

Notes for the reviewer

Test plan

  • Manifest consistency: .npmrc target/ms_build_id, package.json, package-lock.json, cgmanifest.json, build/checksums/electron.txt all agree on 42.8.0
  • typecheck-client passes against Electron 42.8.0 typings (auth.ts relies on upstream firstAuthAttempt)
  • Launch smoke: release/1.132 code transpiled and unit tests run green under the actual Electron 42.8.0 binary (macOS)
  • Windows validation: the crash path (standard user + system install) can't be reproduced locally on macOS — relies on the reporter's confirmation that Insiders 1.133.0 (42.8.0) fixes it
  • If a recovery prerelease artifact is produced, ask the reporter to validate it in the original environment (Intune system install + standard user)

cc Robo (@deepak1556)

Cherry-picks the Electron 42.8.0 runtime bump onto release/1.132.
Standard (non-admin) Windows users hit a startup crash loop in 1.132.0
(GPU process launch failed error_code=57, crashpad handler self-terminates);
1.133 Insiders with 42.8.0 no longer reproduces. No VS Code launch-path
changes exist between release/1.132 and main, so the runtime is the fix.

Fixes microsoft#329530

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports Electron 42.8.0 to address the Windows standard-user startup crash.

Changes:

  • Updates Electron dependencies and build metadata.
  • Refreshes Electron artifact checksums.
  • Uses Electron’s upstream firstAuthAttempt typing.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.npmrc Updates Electron build target.
package.json Bumps Electron dependency.
package-lock.json Locks Electron 42.8.0.
cgmanifest.json Updates component metadata.
build/checksums/electron.txt Updates runtime artifact checksums.
src/vs/platform/native/electron-main/auth.ts Uses the upstream authentication type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants