[cherry-pick] chore: bump electron@42.8.0 to fix standard-user startup crash - #329594
Open
Akshat Anand (cipheraxat) wants to merge 1 commit into
Open
Conversation
Cherry-picks the Electron 42.8.0 runtime bump onto release/1.132. Standard (non-admin) Windows users hit a startup crash loop in 1.132.0 (GPU process launch failed error_code=57, crashpad handler self-terminates); 1.133 Insiders with 42.8.0 no longer reproduces. No VS Code launch-path changes exist between release/1.132 and main, so the runtime is the fix. Fixes microsoft#329530
Contributor
There was a problem hiding this comment.
Pull request overview
Backports Electron 42.8.0 to address the Windows standard-user startup crash.
Changes:
- Updates Electron dependencies and build metadata.
- Refreshes Electron artifact checksums.
- Uses Electron’s upstream
firstAuthAttempttyping.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.npmrc |
Updates Electron build target. |
package.json |
Bumps Electron dependency. |
package-lock.json |
Locks Electron 42.8.0. |
cgmanifest.json |
Updates component metadata. |
build/checksums/electron.txt |
Updates runtime artifact checksums. |
src/vs/platform/native/electron-main/auth.ts |
Uses the upstream authentication type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the Electron 42.8.0 runtime bump from #328712 onto
release/1.132.Fixes #329530 — on 1.132.0 (system install), launching Code as a standard Windows user (no admin rights) crash-loops at startup:
GPU process launch failed: error_code=57(repeats untilGPU process isn't usable. Goodbye.)reason: launch-failed, code: 57crash server failed to launch, self-terminatingThe reporter confirmed 1.133.0 Insiders (Electron 42.8.0) does not crash with the same steps. I diffed every launch-related path between
release/1.132andmain(src/main.ts,src/vs/code/,src/vs/platform/windows/electron-main/, crashpad config,build/win32/,resources/win32/) and found zero changes — the only difference between the crashing build and the working one is the Electron runtime, so this is not fixable in VS Code source. #328712 also references the internal runtime fix (vscode-internalbacklog#8662).The only conflict was
package.json'sversion/distro, resolved to keep the release branch's1.132.0/b2ef7d8...pins.Notes for the reviewer
distroto0a2adcd...; this cherry-pick intentionally keeps release/1.132'sb2ef7d8...since that repo is version-specific. I can't verify from outside whether the distro move is required to build againstms_build_id=14845705— Robo (@deepak1556) could you confirm the release distro pin works with this ms_build, or should the distro bump come along too?getSystemMemoryInfofeature and two behavior fixes (macOS window-occlusion throttling fix: don't treat transparent overlays as occluders on macOS electron/electron#52390, ICO temp files fix: Electron creates temporary icon files and does not delete them after use electron/electron#52479). The occlusion fix is user-visible on macOS. If you'd rather keep the recovery minimal, the alternative is a 42.7.2 runtime patch with only the child-process fix — happy to retarget this PR if that lands instead.Test plan
.npmrctarget/ms_build_id,package.json,package-lock.json,cgmanifest.json,build/checksums/electron.txtall agree on 42.8.0typecheck-clientpasses against Electron 42.8.0 typings (auth.tsrelies on upstreamfirstAuthAttempt)cc Robo (@deepak1556)