Agent host: submit auto-approved review comments - #329592
Open
Benjamin Christopher Simmonds (benibenj) wants to merge 4 commits into
Open
Agent host: submit auto-approved review comments#329592Benjamin Christopher Simmonds (benibenj) wants to merge 4 commits into
Benjamin Christopher Simmonds (benibenj) wants to merge 4 commits into
Conversation
Preserve automatic approval context for server tools so viewUnreviewedComments submits and returns every unreviewed PR and code-review comment when no picker is shown, while retaining interactive selection behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
August 7, 2026 14:09
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
August 7, 2026 14:11
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds automatic-approval context so feedback tools can submit all unreviewed review comments without opening the picker.
Changes:
- Propagates approval context through Copilot and Codex server-tool execution.
- Auto-submits unreviewed PR/code-review comments.
- Adds regression tests and documentation.
The Claude execution path does not yet propagate this context.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/SESSIONS.md |
Documents approval behavior. |
src/vs/platform/agentHost/test/node/mockAgent.ts |
Tracks auto-approved permissions. |
src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts |
Tests approval-context distinction. |
src/vs/platform/agentHost/test/node/copilotAgent.test.ts |
Tests option forwarding. |
src/vs/platform/agentHost/test/node/agentSideEffects.test.ts |
Tests automatic approval metadata. |
src/vs/platform/agentHost/test/node/agentFeedbackServerTools.test.ts |
Tests automatic comment submission. |
src/vs/platform/agentHost/node/shared/agentServerToolHost.ts |
Forwards execution context. |
src/vs/platform/agentHost/node/shared/agentFeedbackServerTools.ts |
Submits auto-approved comments. |
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts |
Tracks interactive approvals. |
src/vs/platform/agentHost/node/copilot/copilotAgent.ts |
Forwards permission options. |
src/vs/platform/agentHost/node/codex/codexAgent.ts |
Marks confirmation tools auto-approved. |
src/vs/platform/agentHost/node/agentSideEffects.ts |
Identifies automatic approvals. |
src/vs/platform/agentHost/common/agentService.ts |
Adds permission response options. |
src/vs/platform/agentHost/common/agentServerTools.ts |
Adds server-tool execution context. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 1
- Review effort level: Balanced
| * are invalid. | ||
| */ | ||
| executeTool(sessionUri: URI, toolName: string, rawArgs: unknown): string | Promise<string>; | ||
| executeTool(sessionUri: URI, toolName: string, rawArgs: unknown, context?: IAgentServerToolExecutionContext): string | Promise<string>; |
Contributor
Author
There was a problem hiding this comment.
Will addressee in follow up PR
Henning Dieterichs (hediet)
previously approved these changes
Aug 7, 2026
auto-merge was automatically disabled
August 7, 2026 21:53
Pull request was closed
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
August 7, 2026 21:54
Benjamin Christopher Simmonds (benibenj)
disabled auto-merge
August 7, 2026 22:36
Contributor
Author
|
not ready yet |
Treat an absent explicit picker selection as selecting every unreviewed review comment. This removes provider-specific approval-source tracking while preserving user selections until delivery and preventing empty interactive approvals. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
chat/chatAgentFeedbackReviewConfirmation/Empty/Light
| Before | After |
|---|---|
 |
 |
Make server-tool confirmation session-aware so viewUnreviewedComments runs without prompting when there are no created comments or pending selections, while retaining confirmation whenever revealable comments exist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Tyler James Leonhardt (@TylerLeonhardt)Matched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewUnreviewedCommentssubmit and return every unreviewed PR and code-review commentTesting
Not run, per request.