Skip to content

sessions: hide automations pointer focus outline - #329503

Open
Ben Villalobos (benvillalobos) wants to merge 1 commit into
microsoft:mainfrom
benvillalobos:agents/remove-blue-outline-on-click
Open

sessions: hide automations pointer focus outline#329503
Ben Villalobos (benvillalobos) wants to merge 1 commit into
microsoft:mainfrom
benvillalobos:agents/remove-blue-outline-on-click

Conversation

@benvillalobos

Copy link
Copy Markdown
Member

Summary

  • suppress the redundant Automations custom-view fallback outline
  • preserve keyboard focus indicators on automation cards and controls
  • document the custom-view focus behavior

Validation

  • npm run compile
  • scripts\test.bat --run src\vs\sessions\contrib\sessions\test\browser\automationsView.test.ts (26 passing)
  • npm run typecheck-client
  • npm run valid-layers-check
  • git diff --check

Notes

  • npm run hygiene was attempted but is currently blocked on Windows by existing URL path handling in build/gulpfile.hygiene.ts, which resolves the repository as C:\C:\src\... and fails before checking changes.

Suppress the redundant custom-view fallback outline while preserving keyboard focus indicators on automation cards and controls.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 6, 2026 22:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Suppresses the redundant pointer-focus outline around the Automations custom view while retaining keyboard indicators on interactive elements.

Changes:

  • Marks the Automations host content for targeted styling.
  • Removes the host/widget outline without affecting card and control focus styles.
  • Documents custom-view fallback focus behavior.
Show a summary per file
File Description
src/vs/sessions/LAYOUT.md Documents fallback-outline behavior.
src/vs/sessions/contrib/sessions/browser/views/automationsView.ts Adds the Automations content marker class.
src/vs/sessions/contrib/sessions/browser/media/automationsCards.css Suppresses redundant outer outlines.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants