Skip unchanged mime database updates#318436
Open
aydinomer00 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds the -n flag to update-mime-database invocations in Linux package install/uninstall scripts to skip processing the deprecated .desktop files in the MIME database (improves speed and aligns with modern usage).
Changes:
- Pass
-ntoupdate-mime-databasein Debian postinst/postrm templates. - Pass
-ntoupdate-mime-databasein the RPM spec template (post and postun).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| resources/linux/debian/postinst.template | Add -n flag on install to skip deprecated processing. |
| resources/linux/debian/postrm.template | Add -n flag on removal to skip deprecated processing. |
| resources/linux/rpm/code.spec.template | Add -n flag in both %post and %postun invocations. |
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163690
This updates the Linux package scripts to pass
-ntoupdate-mime-database.The
-noption skips rebuilding the MIME database when it is already up to date, which avoids unnecessary work during package install/update/removal. The Debian package scripts are updated for the reported issue, and the RPM script is updated for consistency.Validation:
git diff --checkbash -n resources/linux/debian/postinst.templatebash -n resources/linux/debian/postrm.templatenvm use && node --experimental-strip-types build/hygiene.ts resources/linux/debian/postinst.template resources/linux/debian/postrm.template resources/linux/rpm/code.spec.template