Allow Exact Match For Filters - #1649
Conversation
|
@microsoft-github-policy-service agree |
|
Thanks, this is a reasonable addition and the trailing-separator approach is backward compatible. One blocker and two smaller asks before merge: Windows separator gap. The typical config form is if (/[\\/]$/.test(exclude)) {
exclude = exclude.slice(0, -1);
isDirect = true;
} else {
isDirect = this.isFilePath(exclude);
}Docs. The trailing-slash convention isn't discoverable — can you update Test. A small unit test covering the new exact-match path in |
|
Changyong Gong (@chagong) I finally got around to addressing the (very good!) feedback :) Can you re-take a peek? |
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
The revised Windows separator handling and tests address the earlier feedback, but the trailing-separator comparison and documentation wording still need adjustment before merge.
|
Changyong Gong (@chagong) I believe i have addressed round 2 feedback! Thanks again! |
I was having cases where filters were matching inappropriately, for example with composite builds. This lets you have an exact match syntax. I know it's a bit niche, but I do think it's useful/I personally use it!