update-app-polling - Fix anonymous notification polling 401 spam.#1002
Merged
Conversation
Contributor
Author
|
@Bionic711 @paullizer This PR turns off polling for unauthenticated users to prevent 401 error log spamming when users get logged out due to idle timeout or load the app page without signing in. Please let me know if you need any updates from me. |
Collaborator
|
This be like some kind of crazy talk. Why on Earth would you not want you app insights and console logs filled with 401 spam? That is what separates the chaff from the real admins! Will review tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/notifications/countafter idle timeout or before sign-in.Validation
git diff --checkpython -m py_compile application/single_app/config.py functional_tests/test_notification_polling_redirect_guard.py ui_tests/test_notifications_polling_redirect_guard.pypython -m compileall -q application/single_apppython scripts/check_xss_sinks.py --full-file application/single_app/templates/base.htmlpytest functional_tests/test_notification_polling_redirect_guard.pyNotes
playwrightpytest fixture.