chore: require explicit timeout parameter in sendMessage() - #1807
Merged
Yury Semikhatsky (yury-s) merged 3 commits intoJun 23, 2025
Conversation
Yury Semikhatsky (yury-s)
requested review from
Simon Knott (Skn0tt),
Dmitry Gozman (dgozman) and
Max Schmitt (mxschmitt)
June 20, 2025 23:18
Dmitry Gozman (dgozman)
approved these changes
Jun 23, 2025
Max Schmitt (mxschmitt)
approved these changes
Jun 23, 2025
Yury Semikhatsky (yury-s)
merged commit Jun 23, 2025
859eb9b
into
microsoft:main
17 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Either
NO_TIMEOUTor computed timeout must be provided for each call tosendMessage(method, params, timeout), so that we can leverage compiler support.