Add custom ops Rotary - #738
Closed
Xavier Dupré (xadupre) wants to merge 14 commits into
Closed
Conversation
Xavier Dupré (xadupre)
marked this pull request as ready for review
June 6, 2024 14:12
Wenbing Li (wenbingl)
previously approved these changes
Jun 6, 2024
Xavier Dupré (xadupre)
dismissed
Wenbing Li (wenbingl)’s stale review
via
June 6, 2024 15:49
f67d3b1
Wenbing Li (wenbingl)
previously approved these changes
Jun 12, 2024
Wei-Sheng Chin (wschin)
suggested changes
Jun 27, 2024
Wei-Sheng Chin (wschin)
left a comment
Wei-Sheng Chin (wschin)
left a comment
There was a problem hiding this comment.
My comments fall into two categories. For documentation, they are must-to-have. The rest are nit and optional. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.