Fix suppressions for unfixable binskim findings#927
Merged
Conversation
The SDL suppression file configured for the Windows release jobs was never being loaded. Guardian logged that the file was "expected at .../gdnsuppress.gdnsuppress but not found": the suppressionFile setting pointed at `.../gdnsuppress`, but Guardian appends the `.gdnsuppress` extension on top of whatever path is supplied, so it was looking for the doubled-up name on disk. Rename the per-platform suppression files to Guardian's default `.gdnsuppress` name and update release.yml to match, so the Windows x64 and ARM64 BinSkim suppressions are actually applied on the next release run. Assisted-by: Claude Opus 4.7 Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDL suppression file configured for the Windows release jobs was
never being loaded. Guardian logged that the file was "expected at
.../gdnsuppress.gdnsuppress but not found": the suppressionFile
setting pointed at
.../gdnsuppress, but Guardian appends the.gdnsuppressextension on top of whatever path is supplied, so itwas looking for the doubled-up name on disk.
Rename the per-platform suppression files to Guardian's default
.gdnsuppressname and update release.yml to match, so the Windowsx64 and ARM64 BinSkim suppressions are actually applied on the next
release run.