feat: Enable libsolv to expose file time to dnf plugins#17972
Open
mbearup wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds libsolv support for exposing RPM-MD file timestamps to future DNF virtual-snapshot plugins.
Changes:
- Parses
<time file="...">metadata intoSOLVABLE_FILETIME. - Adds the patch through a dedicated libsolv overlay.
- Refreshes generated specs and the component lock.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
base/comps/components.toml |
Moves customized libsolv out of the inline imports. |
base/comps/libsolv/libsolv.comp.toml |
Defines the libsolv patch overlay. |
base/comps/libsolv/0002-Make-file-time-available-for-dnf-plugins.patch |
Implements file-time parsing and identifier. |
specs/l/libsolv/libsolv.spec |
Registers the patch and updates release metadata. |
specs/l/libsolv/0002-Make-file-time-available-for-dnf-plugins.patch |
Provides the rendered patch copy. |
locks/libsolv.lock |
Updates the component input fingerprint. |
mbearup
changed the title
… supporting virtual snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To achieve parity with Azure Linux 3, we want to support virtual snapshots (package selection based on file time).
For Azure Linux 4, we want to pursue this as a dnf plugin (vs a direct modification to dnf).
Libsolv does not expose the package file time to dnf plugins, so this PR is a prerequisite in enabling that support.