DO NOT MERGE: Add test package to trigger review flow#17948
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new cowsay component to the Azure Linux distro as a deliberate test artifact — the title explicitly states "DO NOT MERGE: Add test package to trigger review flow." It imports the Fedora cowsay package unchanged in its base form and layers Azure Linux customizations (a "Clippy" cowfile plus a clippysay wrapper) via azldev overlays, then commits the rendered spec, lock, and source files.
I reviewed the changes for correctness against repository conventions:
- The
file-addsources (clippy.cow,clippysay) are byte-identical betweenbase/comps/cowsay/and the renderedspecs/c/cowsay/, as required byCheck Rendered SpecsCI. - Every overlay carries a
description; thespec-insert-tag(Source3/Source4),spec-append-lines(%install/%files), andfile-search-replace(bashcomp) overlays are internally consistent with the rendered spec. - The rendered
Release: 4%{?dist}vs. top%changelogof3.8.4-3is not a defect — it matches established azldev auto-increment behavior (e.g.,mock-core-configsrendersRelease: 7against a44.1-1changelog top).
No concrete code defects were found. The blocking concern is non-technical: it is an explicit throwaway test package that adds a new novelty package to a production enterprise distro, which is not appropriate to merge and requires human judgment.
Changes:
- Adds the
cowsaycomponent definition (cowsay.comp.toml) with 7 overlays that register/install a Clippy cowfile andclippysaywrapper and extend bash completion. - Adds overlay source files (
clippy.cow,clippysay) plus the rendered spec,sourcesmanifest, and lock file. - Explicitly marked DO NOT MERGE — a test package to exercise the review flow.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/cowsay/cowsay.comp.toml |
New component definition with 7 well-described overlays (file-add, spec-insert-tag, spec-append-lines, file-search-replace). |
base/comps/cowsay/clippy.cow |
Overlay source: Clippy cowfile (matches rendered copy). |
base/comps/cowsay/clippysay |
Overlay source: clippysay wrapper script (matches rendered copy). |
specs/c/cowsay/cowsay.spec |
Rendered spec with Source3/4, %install, %files, and completion symlink applied. |
specs/c/cowsay/cowsay.bashcomp |
Rendered bash completion with clippysay appended to the complete line. |
specs/c/cowsay/clippy.cow |
Rendered copy of the Clippy cowfile. |
specs/c/cowsay/clippysay |
Rendered copy of the clippysay wrapper. |
specs/c/cowsay/animalsay |
Upstream Source2 script rendered into the spec dir. |
specs/c/cowsay/sources |
SHA512 manifest for the cowsay-3.8.4.tar.gz tarball. |
locks/cowsay.lock |
azldev-managed lock pinning the upstream/import commit and fingerprints. |
e3b72d4 to
8b6aa17
Compare
No description provided.