fix: extract embedded defaults during dry runs#278
Draft
dmcilvaney with Copilot wants to merge 3 commits into
Draft
fix: extract embedded defaults during dry runs#278dmcilvaney with Copilot wants to merge 3 commits into
dmcilvaney with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix dry-run skips embedded default-config extraction
fix: extract embedded defaults during dry runs
Jul 10, 2026
dmcilvaney
reviewed
Jul 10, 2026
Contributor
Author
There was a problem hiding this comment.
No—it became unused once default extraction was made unconditional. Removed it from LoadProjectConfig and the forwarding app method in 25dcdec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dry-run skipped extracting embedded defaults into azldev’s temporary directory, causing project configuration loading to fail before command execution.
Changes
CopyDirRecursivedry-run-aware.CopyDirRecursiveCrossFSunconditional, matching its contract.