fix: repair main after component-groups metadata + overlay-metadata API drift#274
Merged
liunan-ms merged 1 commit intoJul 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Repairs main after the OverlayMetadata API rework by updating affected unit tests and fixing a broken documentation link introduced by the component-groups metadata change, restoring CI gate health.
Changes:
- Update
internal/projectconfig/loader_test.goto use the new overlay metadata API (OverlayCategoryUpstreamBackport,URLRef,upstream-status). - Fix a broken anchor in
docs/user/reference/config/component-groups.mdlinking intooverlays.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/projectconfig/loader_test.go | Migrates component-group metadata test coverage to the post-rework OverlayMetadata schema/types. |
| docs/user/reference/config/component-groups.md | Fixes the broken reference to the overlay metadata “URL references” section. |
…PI drift The component-groups metadata PR was based on the pre-rework OverlayMetadata API and landed after that rework, leaving main red: - loader_test.go referenced removed identifiers (`OverlayCategoryBackportDistGit`, `BugRef`, `Upstreamable`) and inline TOML using the old `upstreamable` field. Migrated it to `OverlayCategoryUpstreamBackport`, `URLRef`, and `upstream-status`. - component-groups.md linked to a nonexistent `#bug-references` anchor in overlays.md. Updated to the actual `#url-references` heading. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
liunan-ms
force-pushed
the
liunan/fix-group-metadata-test
branch
from
bac86b4 to
f6c0a3f
Compare
trungams
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component-groups metadata PR (#3b8701d) was written against the pre-rework
OverlayMetadataAPI and landed after the API rework, leavingmainred onstatic,unit,coverage,lint, anddocsgates.Failures addressed
internal/projectconfig/loader_test.goreferenced removed identifiers (OverlayCategoryBackportDistGit,BugRef,OverlayMetadata.Upstreamable) and inline TOML using the oldupstreamablefield. Migrated it toOverlayCategoryUpstreamBackport,URLRef, andupstream-status.docs/user/reference/config/component-groups.mdlinked to a nonexistentoverlays.md#bug-referencesanchor. Updated to#url-references, which is the actual heading inoverlays.md.Verification
mage check all✅ (includes lint + static analysis)mage unit✅CI failures referenced: