Skip to content

[dotnet-code] Consolidate todo remaining item filtering #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michelle-clayton-work wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −14
Open

[dotnet-code] Consolidate todo remaining item filtering #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions agent/harness/todo/todo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,7 @@ func (p *Provider) GetRemainingItems(opts ...agent.Option) []Item {
mu.Lock()
defer mu.Unlock()
st := p.loadState(opts)
var remaining []Item
for _, item := range st.Items {
if !item.IsComplete {
remaining = append(remaining, item)
}
}
return remaining
return remainingItems(st.Items)
}

func (p *Provider) loadState(opts []agent.Option) *state {
Expand Down Expand Up @@ -313,13 +307,7 @@ func (p *Provider) createTools(opts []agent.Option) []tool.FuncTool {
mu.Lock()
defer mu.Unlock()
st := p.loadState(opts)
var remaining []Item
for _, item := range st.Items {
if !item.IsComplete {
remaining = append(remaining, item)
}
}
return remaining, nil
return remainingItems(st.Items), nil
},
)

Expand All @@ -340,6 +328,16 @@ func (p *Provider) createTools(opts []agent.Option) []tool.FuncTool {
return []tool.FuncTool{addTool, completeTool, removeTool, getRemainingTool, getAllTool}
}

func remainingItems(items []Item) []Item {
var remaining []Item
for _, item := range items {
if !item.IsComplete {
remaining = append(remaining, item)
}
}
return remaining
}

func formatTodoListMessage(items []Item) string {
if len(items) == 0 {
return "### Current todo list\n- none yet"
Expand Down