Preserve large-integer precision when decoding tool arguments#528
Open
PratikDhanave wants to merge 3 commits into
Open
Preserve large-integer precision when decoding tool arguments#528PratikDhanave wants to merge 3 commits into
PratikDhanave wants to merge 3 commits into
Conversation
applySchema decoded incoming JSON arguments into an interface{} via
json.Unmarshal, which turns every JSON number into a float64. Integer
arguments beyond 2^53 (int64/uint64) were therefore silently truncated
before being re-marshalled and handed to the typed handler — e.g. a tool
called with {"n":9007199254740993} received 9007199254740992.
Decode with json.Decoder.UseNumber() so numbers are preserved as json.Number
and round-trip exactly. Only the input path (Format.Unmarshal) was affected;
the output/Normalize path already operates on the typed value.
Adds a black-box test asserting a 2^53+1 argument round-trips exactly.
There was a problem hiding this comment.
Pull request overview
This PR fixes loss of integer precision (> 2^53) when decoding tool-call JSON arguments by switching the schema-application step to decode numbers as json.Number instead of float64, ensuring large int64/uint64 arguments round-trip correctly into typed handlers.
Changes:
- Update
applySchemato decode JSON withjson.Decoder+UseNumber()to preserve large integer precision. - Add a black-box regression test proving
Format.Unmarshalpreserves a2^53+1integer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| agent/format/jsonformat/encoding.go | Switch argument decoding to UseNumber() in the schema/defaults path to avoid float64 truncation. |
| agent/format/jsonformat/encoding_test.go | Add regression test ensuring Unmarshal preserves large int64 values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+73
to
80
| // Decode with UseNumber so integers beyond 2^53 are not silently | ||
| // truncated by being decoded into float64 and re-marshalled. | ||
| dec := json.NewDecoder(bytes.NewReader(data)) | ||
| dec.UseNumber() | ||
| if err := dec.Decode(&v); err != nil { | ||
| return nil, fmt.Errorf("unmarshaling arguments: %w", err) | ||
| } | ||
| } |
Comment on lines
5
to
9
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "fmt" | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Done — added the io import and a strict trailing-data check (dec.Token() must return io.EOF). Note: validate() can't also use UseNumber — json.Number is a string type the jsonschema validator rejects as a non-integer, which broke every test; left as a comment in the PR.
Comment on lines
+73
to
+77
| // Decode with UseNumber so integers beyond 2^53 are not silently | ||
| // truncated by being decoded into float64 and re-marshalled. | ||
| dec := json.NewDecoder(bytes.NewReader(data)) | ||
| dec.UseNumber() | ||
| if err := dec.Decode(&v); err != nil { |
Address review feedback: switching to json.Decoder for UseNumber made applySchema tolerate trailing data after the first JSON value, unlike the json.Unmarshal it replaced. Restore strict single-value parsing by requiring io.EOF after the decoded value, and add a regression test. (The related suggestion to also decode with UseNumber inside validate() is not applied: json.Number is a string type that the jsonschema validator rejects as a non-integer, so it cannot be used there.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applySchema(agent/format/jsonformat/encoding.go), reached viaFormat.Unmarshal, decodes incoming JSON arguments into aninterface{}withjson.Unmarshal, which turns every JSON number into afloat64. Integer arguments beyond 2^53 are therefore silently truncated before being re-marshalled and handed to the typed handler:Every
functoolcall with anint64/uint64argument is affected. (The output /Normalizepath is not — it operates on the already-typed value and doesn't round-trip through this number-losing step.)Fix
Decode with
json.Decoder+UseNumber(), so numbers are preserved asjson.Numberand round-trip exactly through the re-marshal.Public API
No exported symbols change.
Tests
Adds
TestFormat_Unmarshal_PreservesLargeIntegerPrecision(black-box): a2^53+1argument. It comes back as9007199254740992before this change and exactly9007199254740993after. Full./agent/format/jsonformatand./tool/functoolsuites pass (no regression).