Skip to content

Preserve quoted grammar object keys#2722

Draft
datduyng wants to merge 9 commits into
mainfrom
domnguyen/fix-dfa-phrase-set-false-negatives
Draft

Preserve quoted grammar object keys#2722
datduyng wants to merge 9 commits into
mainfrom
domnguyen/fix-dfa-phrase-set-false-negatives

Conversation

@datduyng

@datduyng datduyng commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Preserve quoted object keys through parsing and formatting so agc format --write cannot corrupt valid grammars.

datduyng and others added 4 commits July 22, 2026 00:04
- Delegate runtime phrase-set hits to the authoritative source NFA
- Cover literal, wildcard, and phrase-length overlap cases
- Exercise acceptance and rejection through the production cache DFA path
- Remove the superseded DFA fallback implementation
- Remove its ActionGrammar and cache regressions
- Restore generated documentation and source to the frozen baseline
- Quote non-identifier keys during grammar formatting
- Cover dashed property names with a round-trip regression
@datduyng datduyng changed the title Prevent DFA cache phrase-set false negatives Preserve quoted grammar object keys Jul 22, 2026
@datduyng

Copy link
Copy Markdown
Contributor Author
image image

datduyng and others added 4 commits July 22, 2026 01:10
- Track quoted property keys in the parser AST.

- Reuse parser identifier rules for generated syntax trees.

- Cover parsed and programmatic writer paths.
- Preserve object-key quotes using parser metadata only
- Remove writer-side identifier reclassification
- Keep programmatic grammar AST behavior unchanged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant