Propagate choice callback failures#2721
Draft
datduyng wants to merge 5 commits into
Draft
Conversation
- Stop and close partial sessions before releasing registered ports - Preserve startup errors and existing pre-session failure caching - Cover cleanup ordering, retry, and concurrent session ownership
- Extract failure cleanup from initializeSessionContext - Preserve the tested stop, close, port release, and retry behavior - Satisfy the repository cognitive-complexity ratchet
- Remove the superseded lifecycle rollback implementation - Remove its specialized failure-injection coverage - Restore the branch to the frozen baseline before the replacement fix
- Let deferred callback errors reject respondToChoice - Cover failure propagation at the public dispatcher boundary
datduyng
changed the title
- Keep the original callback error assertion - Exercise a later chained choice after the rejection - Prove dispatcher cleanup leaves choice handling usable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let hosts surface deferred choice failures instead of reporting them as successful.