Fix coercion through schema unions and type references#2711
Merged
Conversation
- Return coerced primitive values from successful union branches. - Preserve coercion through resolved type references and nested containers. - Add regression coverage for direct, object, and array values.
datduyng
marked this pull request as draft
July 21, 2026 05:25
GeorgeNgMsft
approved these changes
Jul 21, 2026
datduyng
marked this pull request as ready for review
July 21, 2026 20:32
datduyng
enabled auto-merge
July 21, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editorPositionis declared asEditorPosition | number. The input"1"can be coerced to1, but union/type-reference validation discarded that result and left the original string for later validation.This is an inconsistent experience because in https://github.com/microsoft/TypeAgent/blob/15ef5aa0362e3296bd9d6bd2f001fab704375d27/ts/packages/actionSchema/src/validate.ts
we explicitly allowed casting string to number but not at the stored value level.
The fix returns coerced values through union and type-reference wrappers so the parent object stores the declared type.
pr-2711-before-after.mp4