Skip to content

Fixing a bug with regex_Like function as Boolean exp - #166

Merged
Leila Lali (llali) merged 2 commits into
mainfrom
dev/llali/regexlike
Sep 22, 2025
Merged

Fixing a bug with regex_Like function as Boolean exp#166
Leila Lali (llali) merged 2 commits into
mainfrom
dev/llali/regexlike

Conversation

@llali

Copy link
Copy Markdown
Member

Description

Fixes #160
In addition, go through the checklist below and check each item as you validate it is either handled or not applicable to this change.

Code Changes

@clement911

Copy link
Copy Markdown

Note that fixing this bug will hopefully fix #28 at the same time, as I believe it is caused by the same root issue.

@llali

Copy link
Copy Markdown
Member Author

Note that fixing this bug will hopefully fix #28 at the same time, as I believe it is caused by the same root issue.

I don't think so but I'll double check

++insideIIf;
}
// if identifier is REGEXP_LIKE
else if(NextTokenMatches(CodeGenerationSupporter.RegexpLike))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more appropriate to add it to TSql170ParserBaseInternal or whichever version introduces this syntax?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably yes but it's fine since we added other syntaxes here as well. I can rename the function later

@llali
Leila Lali (llali) merged commit cd170a8 into main Sep 22, 2025
8 checks passed
@clement911

Copy link
Copy Markdown

Leila Lali (@llali) could you release this fix so that we can test it out?

@llali

Copy link
Copy Markdown
Member Author

Clement Gutel (@clement911) this should be in 170.128.0

@clement911

Copy link
Copy Markdown

Ah yes thank you Leila Lali (@llali) , confirming it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse error when using REGEXP_LIKE

4 participants