feat(tinylicious): Support command line --port argument#27709
Draft
Josmithr wants to merge 2 commits into
Draft
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. Some pipeline(s) encountered errors during trigger evaluation. |
Contributor
Bundle size comparisonBase commit: Pending — |
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (65 lines, 3 files), I've queued these reviewers:
How this works
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--portargument to thetinyliciouscommand. Previously, the only way to configure the port tinylicious used was via an environment variable. Now, a command line argument is supported as well (and takes precedence over the environment variable when both are set).This is part of a multi-PR effort to allow our repo's tinylicious real service tests to get port assignments dynamically.
This library update needs to be published before the changes can be used in the client packages for their tinylicious tests. But the whole story can be previewed here: #27701.