Skip to content

Recover from structurally corrupt snapshots - #8124

Open
cjen1-msft wants to merge 7 commits into
microsoft:mainfrom
cjen1-msft:test/recovery-corrupt-snapshot-fallback
Open

Recover from structurally corrupt snapshots#8124
cjen1-msft wants to merge 7 commits into
microsoft:mainfrom
cjen1-msft:test/recovery-corrupt-snapshot-fallback

Conversation

@cjen1-msft

@cjen1-msft cjen1-msft commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Previously if snapshot parsing on join and recovery was outside of the try and so could fail and throw.
Now it will be caught and treated identically to how failing validation happens currently - retry with older.

@cjen1-msft
cjen1-msft force-pushed the test/recovery-corrupt-snapshot-fallback branch 2 times, most recently from 8ceb222 to abd64fc Compare August 6, 2026 14:59
@cjen1-msft cjen1-msft changed the title Test recovery fallback from structurally corrupt snapshot Recover from structurally corrupt snapshots Aug 6, 2026
@cjen1-msft
cjen1-msft force-pushed the test/recovery-corrupt-snapshot-fallback branch from 8120f01 to 3ca5d33 Compare August 6, 2026 16:46
@cjen1-msft
cjen1-msft marked this pull request as ready for review August 6, 2026 17:09
@cjen1-msft
cjen1-msft requested a review from a team as a code owner August 6, 2026 17:09
Copilot AI lite review requested due to automatic review settings August 6, 2026 17:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

@achamayou

Copy link
Copy Markdown
Member

cjen1-msft a note in the changelog is a good idea, this is will be a change of behaviour for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants