Use TAV for SNP attestation verification - #8083
Draft
cjen1-msft wants to merge 4 commits into
Draft
Conversation
Merged
cjen1-msft
force-pushed
the
tee-attestation-integration-tav
branch
2 times, most recently
from
July 21, 2026 09:44
a1af44a to
70019d1
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2ec11cce-7838-47b5-be19-21425a3a3bbf
cjen1-msft
force-pushed
the
tee-attestation-integration-tav
branch
from
August 5, 2026 16:26
70019d1 to
b96a3d6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates the TEE Attestation Verification (TAV) FFI crate into CCF’s Rust umbrella (ccf-rs) and switches SEV-SNP attestation verification in the PAL layer to use tav_verify_snp_attestation, while keeping CCF’s existing report parsing and policy checks.
Changes:
- Add the TAV FFI crate to
ccf-rsand update the locked Rust dependency graph. - Replace PAL-side SNP certificate-chain, signature, and TCB verification logic with a TAV verification call and map failures to CCF errors.
- Update SEV-SNP attestation validation tests and build system wiring (Rust build deps, PAL include/link settings).
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rust/src/lib.rs | Re-exports the new TAV FFI crate from the ccf-rs umbrella. |
| src/rust/Cargo.toml | Adds the vendored tee-attestation-verification-ffi dependency with OpenSSL crypto feature. |
| src/rust/Cargo.lock | Locks new transitive dependencies introduced by TAV integration. |
| src/pal/test/snp_attestation_validation.cpp | Adds/updates negative tests to expect TAV failure paths and error codes. |
| src/pal/tav_ffi.h | Introduces RAII wrappers for TAV error/report handles used by PAL. |
| src/pal/attestation.cpp | Replaces local SNP chain/signature verification with tav_verify_snp_attestation and consistent error reporting. |
| CMakeLists.txt | Updates ccf_pal link libraries and adds include path for TAV FFI headers. |
| cmake/ccf_rs.cmake | Ensures the Rust build target reruns when the vendored TAV FFI Cargo.toml changes. |
|
|
||
| [dependencies] | ||
| cose-rs = { path = "../cose/cose_rs" } | ||
| tav = { package = "tee-attestation-verification-ffi", path = "../../3rdparty/internal/tee-attestation-verification/ffi", default-features = false, features = ["crypto_openssl"] } |
| ccf_pal | ||
| SRCS ${CCF_DIR}/src/pal/attestation.cpp | ||
| LINK_LIBS ccfcrypto | ||
| LINK_LIBS ccfcrypto ${CMAKE_THREAD_LIBS_INIT} ${CMAKE_DL_LIBS} m |
cjen1-msft
force-pushed
the
tee-attestation-integration-tav
branch
from
August 6, 2026 17:05
8ad6daa to
06c0172
Compare
cjen1-msft
marked this pull request as draft
August 6, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Summary
ccf-rsumbrellatav_verify_snp_attestationTesting
tav_verify_snp_attestationsymbol checksnp_attestation_test(12 cases, 49 assertions)ccftarget build