Skip to content

Fix duplicate fullBuildPatterns key in AL-Go-Settings.json#9033

Merged
spetersenms merged 1 commit into
mainfrom
spetersen/fixDuplicateFullBuildPattern
Jul 2, 2026
Merged

Fix duplicate fullBuildPatterns key in AL-Go-Settings.json#9033
spetersenms merged 1 commit into
mainfrom
spetersen/fixDuplicateFullBuildPattern

Conversation

@spetersenms

@spetersenms spetersenms commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The second fullBuildPatterns key (added in #8939) silently overrode the original patterns when parsed by ConvertFrom-Json, dropping build/, src/rulesets/ and the workflow patterns. Merge src/Layers/* into the single existing array so all patterns trigger a full build again.

AB#612711

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

The second fullBuildPatterns key (added in #8939) silently overrode the
original patterns when parsed by ConvertFrom-Json, dropping build/*,
src/rulesets/* and the workflow patterns. Merge src/Layers/* into the
single existing array so all patterns trigger a full build again.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@spetersenms
spetersenms requested review from a team July 2, 2026 11:01
@github-actions github-actions Bot added the Build: Automation Workflows and other setup in .github folder label Jul 2, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

PR #9033 changes only .github/AL-Go-Settings.json (an AL-Go build-configuration file), containing no AL source, page, or upgrade-related objects. All AL-domain leaf skills found no matching content: al-performance-review, al-security-review, al-privacy-review, and al-style-review completed with empty findings (no AL tokens/objects in diff); al-upgrade-review and al-ui-review returned not-applicable (no upgrade or page/UI files changed). Super-skill self-review pass found no cross-cutting concerns.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@spetersenms
spetersenms merged commit 2d11786 into main Jul 2, 2026
55 checks passed
@spetersenms
spetersenms deleted the spetersen/fixDuplicateFullBuildPattern branch July 2, 2026 11:16
alexei-dobriansky pushed a commit that referenced this pull request Jul 2, 2026
The second fullBuildPatterns key (added in #8939) silently overrode the
original patterns when parsed by ConvertFrom-Json, dropping build/*,
src/rulesets/* and the workflow patterns. Merge src/Layers/* into the
single existing array so all patterns trigger a full build again.


[AB#612711](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/612711)

## How I validated this

- [ ] I read the full diff and it contains only changes I intended.
- [ ] I built the affected app(s) locally with no new analyzer warnings.
- [ ] I ran the change in Business Central and confirmed it behaves as
expected.
- [ ] I added or updated tests for the new behavior, or explained below
why none are needed.

**What I tested and the outcome** *(required — be specific: scenarios,
commands, screenshots for UI changes)*

<!-- Example:
- Ran the new "Post and Send" action on a sales invoice in a fresh
container; document posted and email queued (see screenshot).
- New unit tests in MyFeatureTest.Codeunit.al pass locally; full module
test suite green.
- No tests added because change is comment-only / refactor with existing
coverage. -->

## Risk & compatibility

<!-- Anything reviewers should watch for: breaking changes, upgrade/data
impact, permissions,
telemetry, feature flags, follow-up work. Write "None" if there's
nothing to call out. -->

Co-authored-by: spetersenms <spetersenms@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: Automation Workflows and other setup in .github folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants