Skip to content

Draft Proposal: Add targeted profiling feature - #4833

Draft
John (johnoliver) wants to merge 2 commits into
microsoft:mainfrom
johnoliver:targeted-profiling
Draft

Draft Proposal: Add targeted profiling feature#4833
John (johnoliver) wants to merge 2 commits into
microsoft:mainfrom
johnoliver:targeted-profiling

Conversation

@johnoliver

Copy link
Copy Markdown
Member

This pull request adds support for Java agent profiling based on targeted collection plans, allowing profiling to be triggered for specific cloud roles or role-qualified instances. It introduces new configuration classes and logic to handle these targeted plans, updates the alerting subsystem to support them, and refactors how manual triggers are tracked and executed. The changes also include enhancements to configuration APIs and internal tracking for executed triggers.

Targeted Profiling Support:

  • Added new configuration classes: TargetedCollectionPlanConfiguration and TargetedInstanceConfiguration to define and validate targeted profiling plans for specific roles or instances. These classes provide methods to check if a plan applies to the current instance and if it is actionable based on expiration and selection criteria. [1] [2]
  • Updated AlertingConfiguration to optionally include a TargetedCollectionPlanConfiguration, and enhanced the API to determine if a profiling trigger is enabled for a given role or instance at a specific time. [1] [2]

Alerting Subsystem Enhancements:

  • Refactored AlertingSubsystem to support targeted collection plan triggers, including new logic to evaluate and dispatch alerts for targeted plans, and to pass role and instance information throughout the subsystem. [1] [2] [3] [4] [5] [6]
  • Introduced AlertingSubsystemConfiguration to encapsulate subsystem-level configuration, including role and instance identifiers.

Manual Trigger Execution Tracking:

  • Replaced the previous manualTriggersExecuted set with a new ExecutedMonikerTracker utility, which tracks executed triggers with retention and capacity limits to prevent duplicate profiling within a time window. [1] [2]

Documentation and Test Updates:

  • Updated CHANGELOG.md to document the addition of Java agent support for targeted collection plans.
  • Updated imports and test setup to include new configuration classes and collections for targeted profiling.Fix # .

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated

@johnoliver John (johnoliver) changed the title Proposal: Add targeted profiling feature Draft Proposal: Add targeted profiling feature Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant