Skip to content

fix: only deliver artifact with same type as artifact to upload as release artifact #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OleWunschmann wants to merge 6 commits into
base: main
Choose a base branch
from
+43 −8
Open

fix: only deliver artifact with same type as artifact to upload as release artifact #2321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d813a0f
fix: only deliver artifact with same type as artifact to upload as re…
OleWunschmann Jul 17, 2026
ec2f4aa
Potential fix for pull request finding
OleWunschmann Jul 17, 2026
2025290
fix: only deliver artifact with same type as artifact to upload as re…
OleWunschmann Jul 17, 2026
4496689
Updated releasenotes
OleWunschmann Jul 17, 2026
6932a2c
Merge branch 'main' into fix-deliver-to-of-release-workflow
OleWunschmann Jul 20, 2026
3f83e54
Merge branch 'main' into fix-deliver-to-of-release-workflow
OleWunschmann Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASENOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Workspace compilation now finds altool both in the platform-specific subfolder (
- Retry downloading dependency artifacts from the current build up to 3 times (30 seconds between attempts) to tolerate transient network errors such as "Failed to GetSignedArtifactURL: Unable to make request: ETIMEDOUT"
- Issue 2302 - AlDoc does not use --packagecache when building reference documentation
- Issue 2319 - Under workspace compilation, `enableCodeAnalyzersOnTestApps: false` now also disables custom analyzers (`customCodeCops`) for test apps and BCPT test apps, not just the built-in code analyzers.
- Issue 2320 - Deliver to NuGet of release workflow failing with app and test app

## v9.1

Expand Down
25 changes: 21 additions & 4 deletions Templates/AppSource App/.github/workflows/CreateRelease.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,26 @@ jobs:
data: fs.readFileSync(assetPath)
});

- name: Determine delivery targets
id: determineDeliveryTargets
env:
hasNuGetContext: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).nuGetContext != '' }}
hasStorageContext: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).storageContext != '' }}
MATRIX_ATYPE: ${{ matrix.atype }}
run: |
$errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0

$deliverToNuGet = $env:hasNuGetContext -eq 'true' -and $env:MATRIX_ATYPE -in @("Apps", "TestApps")
Write-Host "Deliver $($env:MATRIX_ATYPE) to NuGet: $deliverToNuGet"
Add-Content -Encoding UTF8 -Path $env:GITHUB_OUTPUT -Value "deliverToNuGet=$($deliverToNuGet.ToString().ToLower())"

$deliverToStorage = $env:hasStorageContext -eq 'true' -and $env:MATRIX_ATYPE -in @("Apps", "TestApps", "Dependencies")
Write-Host "Deliver $($env:MATRIX_ATYPE) to Storage: $deliverToStorage"
Add-Content -Encoding UTF8 -Path $env:GITHUB_OUTPUT -Value "deliverToStorage=$($deliverToStorage.ToString().ToLower())"

- name: Deliver to NuGet
uses: microsoft/AL-Go-Actions/Deliver@main
if: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).nuGetContext != '' }}
if: ${{ steps.determineDeliveryTargets.outputs.deliverToNuGet == 'true' }}
env:
Secrets: '${{ steps.ReadSecrets.outputs.Secrets }}'
with:
Expand All @@ -250,11 +267,11 @@ jobs:
projects: ${{ matrix.project }}
deliveryTarget: 'NuGet'
artifacts: ${{ github.event.inputs.buildVersion }}
atypes: 'Apps,TestApps'
atypes: ${{ matrix.atype }}

- name: Deliver to Storage
uses: microsoft/AL-Go-Actions/Deliver@main
if: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).storageContext != '' }}
if: ${{ steps.determineDeliveryTargets.outputs.deliverToStorage == 'true' }}
env:
Secrets: '${{ steps.ReadSecrets.outputs.Secrets }}'
with:
Expand All @@ -263,7 +280,7 @@ jobs:
projects: ${{ matrix.project }}
deliveryTarget: 'Storage'
artifacts: ${{ github.event.inputs.buildVersion }}
atypes: 'Apps,TestApps,Dependencies'
atypes: ${{ matrix.atype }}

CreateReleaseBranch:
needs: [ CreateRelease, UploadArtifacts ]
Expand Down
25 changes: 21 additions & 4 deletions Templates/Per Tenant Extension/.github/workflows/CreateRelease.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,26 @@ jobs:
data: fs.readFileSync(assetPath)
});

- name: Determine delivery targets
Comment thread
OleWunschmann marked this conversation as resolved.
id: determineDeliveryTargets
env:
hasNuGetContext: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).nuGetContext != '' }}
hasStorageContext: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).storageContext != '' }}
MATRIX_ATYPE: ${{ matrix.atype }}
run: |
$errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0

$deliverToNuGet = $env:hasNuGetContext -eq 'true' -and $env:MATRIX_ATYPE -in @("Apps", "TestApps")
Write-Host "Deliver $($env:MATRIX_ATYPE) to NuGet: $deliverToNuGet"
Add-Content -Encoding UTF8 -Path $env:GITHUB_OUTPUT -Value "deliverToNuGet=$($deliverToNuGet.ToString().ToLower())"

$deliverToStorage = $env:hasStorageContext -eq 'true' -and $env:MATRIX_ATYPE -in @("Apps", "TestApps", "Dependencies")
Write-Host "Deliver $($env:MATRIX_ATYPE) to Storage: $deliverToStorage"
Add-Content -Encoding UTF8 -Path $env:GITHUB_OUTPUT -Value "deliverToStorage=$($deliverToStorage.ToString().ToLower())"

- name: Deliver to NuGet
uses: microsoft/AL-Go-Actions/Deliver@main
if: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).nuGetContext != '' }}
if: ${{ steps.determineDeliveryTargets.outputs.deliverToNuGet == 'true' }}
env:
Secrets: '${{ steps.ReadSecrets.outputs.Secrets }}'
with:
Expand All @@ -250,11 +267,11 @@ jobs:
projects: ${{ matrix.project }}
deliveryTarget: 'NuGet'
artifacts: ${{ github.event.inputs.buildVersion }}
atypes: 'Apps,TestApps'
atypes: ${{ matrix.atype }}

- name: Deliver to Storage
uses: microsoft/AL-Go-Actions/Deliver@main
if: ${{ fromJson(steps.ReadSecrets.outputs.Secrets).storageContext != '' }}
if: ${{ steps.determineDeliveryTargets.outputs.deliverToStorage == 'true' }}
env:
Secrets: '${{ steps.ReadSecrets.outputs.Secrets }}'
with:
Expand All @@ -263,7 +280,7 @@ jobs:
projects: ${{ matrix.project }}
deliveryTarget: 'Storage'
artifacts: ${{ github.event.inputs.buildVersion }}
atypes: 'Apps,TestApps,Dependencies'
atypes: ${{ matrix.atype }}

CreateReleaseBranch:
needs: [ CreateRelease, UploadArtifacts ]
Expand Down