refactor(cli): remove the legacy exit shim and enforce it in CI - #491
Merged
Conversation
Contributor
Author
Vaishnav88sk
previously requested changes
Jul 31, 2026
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Caesarsage
force-pushed
the
pr3/remove-legacy-shim
branch
from
August 2, 2026 10:02
481a7b8 to
884714b
Compare
Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
Contributor
Author
|
Hello @Vaishnav88sk and @Harsh4902 I have attended to all the issues here and from the other PR (merged) here instead of raising a separate PR. And i also added a CI guard to check for missing policies, like missing copyright header, ignored-error and stray-exit |
Vaishnav88sk
reviewed
Aug 2, 2026
|
LGTM 👍🏻 |
Contributor
Author
|
@Harishrs2006 kindly take a look and approve |
Contributor
Author
Harsh4902
dismissed
Vaishnav88sk’s stale review
August 12, 2026 09:41
Dismissing this as @Vaishvan88sk's has already commented LGTM
Harsh4902
added
component/cli
lfx-mentorship
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Microcks CLI v2 work (#255). Stacked on PR #490.
CheckError/CheckConfigNil/Fatal+ErrorGenericshim frompkg/errors; converts the standalonewatcher/binary to handle errors inline.go test ./...tobuild-verify.yml(the pipeline previously only built) and a guard step that fails ifos.Exit/log.Fatal/panicreappears outsidecmd/exit.go.CONTRIBUTING.md.Scope
Pure cleanup: nothing referenced the shim after PR #490.
The only process exits left in the tree are the two
mainentrypoints andcmd.Handle.