You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR Review: stg_orders & stg_payments — Tag Rename finance → fin
Summary: 🟡 Medium risk — The change itself is trivial (metadata only, no SQL or schema changes), but the tag finance is an existing, active tag in the project. Renaming it without updating all references will cause tag fragmentation.
Tag Fragmentation Risk
The tag finance currently exists in the project's tag catalog. After this rename, fin will be a new tag while finance persists on any other assets that still use it. This will:
Split filtering/alerting logic relying on the finance tag across two inconsistent values.
Break any alert routing rules, Elementary monitors, or BI dashboards scoped to the finance tag.
Action required: Confirm that all other assets using the finance tag are also updated in this PR, or that the old tag is intentionally being retired from these two models only.
Downstream Impact
Both models have significant downstream blast radius (9 assets total across 2 hops), including orders, customers, and several anomaly detection models. No direct risk from this change, but if tag-based alerting or routing is configured for finance, those downstream assets may also be affected indirectly.
No SQL / Schema Changes
No logic, column, or join changes — no data correctness or performance concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
financetag tofinonstg_ordersandstg_paymentsinmodels/staging/schema.yml.Created by:
michael@elementary-data.com