Skip to content

Michael Myaskovsky via Elementary: Rename finance tag to fin in staging schema#239

Open
elementary-data-local[bot] wants to merge 1 commit into
mainfrom
elementary-rename-finance-tag-to-fin
Open

Michael Myaskovsky via Elementary: Rename finance tag to fin in staging schema#239
elementary-data-local[bot] wants to merge 1 commit into
mainfrom
elementary-rename-finance-tag-to-fin

Conversation

@elementary-data-local

Copy link
Copy Markdown

Renames the finance tag to fin on stg_orders and stg_payments in models/staging/schema.yml.

Created by: michael@elementary-data.com

@github-actions

Copy link
Copy Markdown

PR Review: stg_orders & stg_payments — Tag Rename financefin

Summary: 🟡 Medium risk — The change itself is trivial (metadata only, no SQL or schema changes), but the tag finance is an existing, active tag in the project. Renaming it without updating all references will cause tag fragmentation.

Tag Fragmentation Risk

The tag finance currently exists in the project's tag catalog. After this rename, fin will be a new tag while finance persists on any other assets that still use it. This will:

  • Split filtering/alerting logic relying on the finance tag across two inconsistent values.
  • Break any alert routing rules, Elementary monitors, or BI dashboards scoped to the finance tag.

Action required: Confirm that all other assets using the finance tag are also updated in this PR, or that the old tag is intentionally being retired from these two models only.

Downstream Impact

Both models have significant downstream blast radius (9 assets total across 2 hops), including orders, customers, and several anomaly detection models. No direct risk from this change, but if tag-based alerting or routing is configured for finance, those downstream assets may also be affected indirectly.

No SQL / Schema Changes

No logic, column, or join changes — no data correctness or performance concerns.

Posted by Elementary CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants