Skip to content

breaking change #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-myaskovsky wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

breaking change #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0839a2f
breaking change
michael-myaskovsky Jul 8, 2026
c8f2c65
another breaking change
michael-myaskovsky Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions models/staging/stg_orders.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ renamed as (

select
id as order_id,
user_id as customer_id,
user_id as client_id,

@elementary-data-dev elementary-data-dev Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking rename: customer_id → client_id propagates to 5 downstream columns (orders, artificial_anomaly, date_based_anomaly, forced_anomaly, returned_orders). All downstream references must be updated in this PR or a compatibility alias added.

order_date,
status

from source

)

select * from renamed
select * from named

@elementary-data-dev elementary-data-dev Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: named is not a defined CTE — the CTE is called renamed. This will cause a compile/runtime error and break all 9 downstream assets.