Update quantile mapping acceptance test data - #143
Open
gavinevans wants to merge 6 commits into
Open
Conversation
… for the occurrence threshold approach.
…features are either mostly overlapping or mostly not overlapping.
2 tasks
gavinevans
marked this pull request as ready for review
July 31, 2026 07:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to metoppv/improver#2423
Acceptance test data is plotted below:
"Overlapping" acceptance tests where most of the precipitation features are in the same location in the reference and the forecast.
"Discrete" acceptance tests where most of the precipitation features are in different locations in the reference and forecast. With the preservation threshold approach, this can generate clear artefacts, as the precipitation is restricted, spatially, to where it was present in the reference forecast.
Acceptance test updates to include passing a non-occurrence value to the CLI are shown below. The main point is the is the non-occurrence value is set as 0.01 mm/hr, the difference plot between the occurrence step (0 mm/hr non-occurrence value) and the occurrence step (0.01 mm/hr non-occurrence value) shows a constant difference where areas of previously zero precipitation have become 0.01 mm/hr, if this is value is used to define the occurrence of an event.