chore: bump pluggable-widgets-tools to 11.12.0 - #2304
Open
samuelreichert wants to merge 11 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
gjulivan
previously approved these changes
Jul 3, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
samuelreichert
force-pushed
the
chore/bump-pluggable-widgets-tools-11.12.0
branch
from
July 29, 2026 13:43
7629994 to
cce94cb
Compare
This comment has been minimized.
This comment has been minimized.
- Bump @mendix/pluggable-widgets-tools 11.11.0 → 11.12.0 - Regenerate patch for 11.12.0 (versioned filename, updated context lines) - rich-text-web: remove preset: "ts-jest" incompatible with new @swc/jest runner - dropdown-sort-web: remove pinned jest@29 devDep (conflicts with pwt jest@30), rename jest.config.cjs → jest.config.js, fix test script to use --projects flag Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove unused @types/enzyme devDependency from dropdown-sort-web and drop redundant testEnvironment override from rich-text-web jest config. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
samuelreichert
force-pushed
the
chore/bump-pluggable-widgets-tools-11.12.0
branch
from
August 10, 2026 14:02
0a9bc04 to
76a0f0b
Compare
This comment has been minimized.
This comment has been minimized.
@swc/jest hoists the jest.mock factory ahead of the outer const it referenced, throwing before initialization. Mock with an inline jest.fn() and pull the reference from the mocked import instead.
`declare const enum DocumentStatus` relied on cross-file const-enum inlining that ts-jest performed but @swc/jest does not, leaving DocumentStatus undefined at runtime. Use a regular enum instead. Also move PDFViewer's cMap/font URL options into a useMemo instead of computing them at module load time, so the spec can exercise different window.mx states via re-render instead of jest.resetModules() + a fresh require() of react-pdf/RTL, which registers global hooks mid-test and jest-circus rejects.
A beforeEach lived in a describe block with no test of its own, with the intended test declared as a sibling instead. jest-circus (used since the pluggable-widgets-tools bump) rejects that structure outright. Move the test inside the correct describe block.
… parent state TableToolbar and TableClipboard declared class fields (container, handlers, controls, update, convert) without initializers, intending them as type annotations only. Under swc's ES2019 target these compile to real `this.x = undefined` assignments run right after super(), wiping out values the parent Toolbar/Clipboard constructor had just set — crashing table init on querySelectorAll of an undefined container. ts-jest did not emit these assignments. Mark the fields `declare` so no initializer is emitted. Also updates the RichText snapshot, which had captured a duplicate-menu artifact from the crash/remount cycle prior to this fix.
r0b1n
reviewed
Aug 12, 2026
Comment on lines
19
to
34
| @@ -28,7 +28,7 @@ index 4998ce2d2bedd449b0fdaa400368df116e1d4f46..d8e70107c4cde83908324b69b1031ad9 | |||
| allowAllFormats: true | |||
| }, | |||
| external: outputFormat === "es" ? [] : webExternal, | |||
| @@ -166,7 +166,7 @@ export default async args => { | |||
| @@ -157,7 +157,7 @@ export default async args => { | |||
| sourceMaps: !production, | |||
| extensions, | |||
| transpile: production, | |||
Collaborator
There was a problem hiding this comment.
this part of the patch looks unnecessary, I see no changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Dependency changes (any modification to dependencies in
package.json)Description