[WC-3522] fix RTL label alignment for control-label/checkbox/radio - #326
Open
yordan-st wants to merge 1 commit into
Open
[WC-3522] fix RTL label alignment for control-label/checkbox/radio#326yordan-st wants to merge 1 commit into
yordan-st wants to merge 1 commit into
Conversation
Previous fix was reverted by a later change. Switched to logical properties so RTL works without separate [dir=rtl] overrides.
yordan-st
marked this pull request as ready for review
August 11, 2026 13:08
r0b1n
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text-align: lefton.control-label) was silently reverted by a later, unrelated "form edit styling fix" commit. Checkbox/radio label gutters never had RTL support after the Atlas 4 rewrite dropped legacy bootstrap-rtl handling.text-align: start,margin-inline-start,padding-inline-end) in_input.scss,_check-box.scss,_radio-button.scssso RTL works without separate[dir=rtl]overrides.Test plan
dir="rtl"fixture):.control-labeltext-align resolves to logicalstart, checkbox/radio label gutter moves frommargin-lefttomargin-rightunder RTL.Ticket: WC-3522