Import 3 x imaging instruments from various sources#2569
Open
willend wants to merge 31 commits into
Open
Conversation
Mads Bertelsen and Victor Holm (EU PaNOSC related work)
Contributor
Author
Contributor
Author
Contributor
Author
|
@jorobledo, @farhi here comes the 3 x imaging instruments discussed elsewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.











Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Import of:
Radiography_Li_battery(Mads Bertelsen & Viktor Holm)Radiography_Sword(Mads Bertelsen & Viktor Holm)PSI_ICON(Peter Willendrup & Estrid B. Naver)Declaration of use of AI-tools
No AI this time round. Just me… ;-)
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
macOS Tahoe, conda-forge dev-tools
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes a new component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mccode-clangformattool to apply the standard McCode component indentation schemecontribcomponent categoryMy contribution includes a new instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)%Example:line to describe expected behaviourmcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedexampleshierarchy in a folder in the style ofexamples/ESS/New_stuff/New_stuff.instrexamplefolder, but if general use I have placed it in the globaldatafolder.