Skip to content

mcviewtest: spawn the new mcplotdiff-html plotter#2568

Open
willend wants to merge 9 commits into
mainfrom
mcviewtest-spawn-diff-plotter
Open

mcviewtest: spawn the new mcplotdiff-html plotter#2568
willend wants to merge 9 commits into
mainfrom
mcviewtest-spawn-diff-plotter

Conversation

@willend

@willend willend commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:


Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Furter, please describe how / where and for what the tools were used:

Claude, prompt:

"Now I'd like you to focus on the mcviewtest tool which is part of tools/Python/mctest/.

The mctest tool can generate a set of test data for McStas, based on %Example lines in the instr files. As part of this, it calls the mcplot-html plotter per test result.

The folder structure from an mctest can be found at e.g. http://new-nightly.mcstas.org/todays-datafiles/mcstas-3.99.99_mpi_x_20_1e7_Linux_20260709_0902_23/

Afterwards, mcviewtest is called to generate an overview table - including columns that correspond e.g. to CPU and GPU execution - or different operating systems, see the html file at http://new-nightly.mcstas.org/todays-datafiles/2026-07-09_output.html (spans the above mctest output + 2 other mctest's.

Consider the first column in the html file the 'reference' test. Comparing each of the OTHER columns to the first one, I'd like you to add 'difference' cells corresponding to a mcplotdiff-html comparion between the dataset outputs, e.g. McStas_8GPU_openacc_mpi_x_7_1e7_Linux_20260709_0001_06_1e7/BNL_H8/1/ and mcstas-3.99.99_mpi_x_20_1e7_Linux_20260709_0902_23/BNL_H8/1/ - adding a link the the mcviewtest template."

Various local adaptation added


Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution contains something else

    • Explanation is added in free form text above or below the checklist

@willend willend marked this pull request as draft July 9, 2026 20:23
@willend

willend commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

A first demo of what this can do is available through http://new-nightly.mcstas.org/demo-diffplots/2026-07-09_output.html. Where possible (simulation worked and produced ascii output), the other datasets are compared against the left-most column (“ref”).

While this still has rough edges (e.g. very long legends on links etc.) I think it will be very useful for instantly getting a good idea of what is up when a test starts to fail numerically.

@willend

willend commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

With the latest few commits (at 5ac3e2c) the output got a couple of stylistic changes.

Overview:
Screenshot 2026-07-10 at 11 03 06
(DIFF separated from rest of cell with a <hr>)

Diffplot:
Screenshot 2026-07-10 at 11 03 13
(Datasets labeled ‘A’ and ‘B’ in header, referral to these in link labels)

@willend

willend commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

After last commit, individual ‘monitor’ plots look like this:
Screenshot 2026-07-10 at 11 18 40
Screenshot 2026-07-10 at 11 18 29
(with link to the underlying ascii datafiles)

where as the ‘diff-monitor’ plots look like this:
Screenshot 2026-07-10 at 11 19 46
Screenshot 2026-07-10 at 11 19 56
(the ascii data do not exist in ‘physical form’)

@willend willend marked this pull request as ready for review July 10, 2026 09:20
@willend willend changed the title DRAFT: mcviewtest: spawn the new mcplotdiff-html plotter mcviewtest: spawn the new mcplotdiff-html plotter Jul 10, 2026
@willend willend requested a review from mads-bertelsen July 10, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant