fix: honour a boolean option written as a bare YAML false - #42
Merged
Conversation
The shared metadata accessor guarded on truthiness, so `auto-filename: false` and its siblings were read as absent and the default applied in their place. Only the quoted string worked, which the site itself had adopted. Also corrects the reference and the examples page. They said a derived filename frames nothing in HTML, which is wrong: Quarto builds its wrapper before this filter runs, so the block carries a marker class instead and the injected script builds the window at page load, as it does for the rest of the HTML chrome. Checked in a browser rather than in the static output.
This was referenced Aug 1, 2026
This was referenced Aug 1, 2026
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared metadata accessor guarded on truthiness, so
auto-filename: falseand its siblings were read as absent and the default applied instead. Only the quoted string worked, which this site had adopted.Verified in a browser, since the HTML chrome is assembled by script at page load and a static grep cannot see it:
The same check also disproves a claim the documentation carried, that a derived filename frames nothing in HTML. With
auto-filename: truethe block is framed and titledyaml, by the script rather than by Quarto's wrapper. The reference and the examples page are corrected, and the site drops the quoted workaround.